[clang-format] Support text proto extensions
ClosedPublic

Authored by krasimir on Feb 12 2018, 5:18 AM.

Details

Summary

This adds support for text proto extensions, like:

msg {
  [type.type/ext] {
    key: value
  }
}

Diff Detail

Repository
rC Clang
krasimir created this revision.Feb 12 2018, 5:18 AM
djasper added inline comments.Feb 12 2018, 7:05 AM
unittests/Format/FormatTestTextProto.cpp
317

It might be useful to attach a test case for what happens if the "[...]" does not fit on one line. I don't even know how I would format that, but it seems important to know and not accidentally modify the behavior.

krasimir updated this revision to Diff 133872.Feb 12 2018, 8:44 AM
  • Add tests with long [...]
krasimir marked an inline comment as done.Feb 12 2018, 8:45 AM
krasimir added inline comments.
unittests/Format/FormatTestTextProto.cpp
317

I added some tests. The current behavior seems reasonable.

krasimir marked an inline comment as done.Feb 12 2018, 11:33 AM
djasper accepted this revision.Feb 12 2018, 11:28 PM

Cool, thanks.

This revision is now accepted and ready to land.Feb 12 2018, 11:28 PM
This revision was automatically updated to reflect the committed changes.