This is an archive of the discontinued LLVM Phabricator instance.

Differential D43169

Include <sys/time.h> to get struct timeval definition
ClosedPublic

Authored by dim on Feb 11 2018, 11:45 AM.

Details

Reviewers
hfinkel
homerdin
Commits
rOLDT325026: Include <sys/time.h> to get struct timeval definition
rL325026: Include <sys/time.h> to get struct timeval definition
Summary

While building the test suite on FreeBSD, I encountered an error due to
struct timeval being unknown in CLAMR's partition.cpp. Add an include
of <sys/time.h> to fix it.

Diff Detail

Event Timeline

dim created this revision.Feb 11 2018, 11:45 AM
Herald added a subscriber: krytarowski. · View Herald TranscriptFeb 11 2018, 11:45 AM
krytarowski added a comment.Feb 11 2018, 12:06 PM

Looks good.

hfinkel accepted this revision.Feb 12 2018, 7:25 PM
In D43169#1004577, @krytarowski wrote:

Looks good.

LGTM too.

This revision is now accepted and ready to land.Feb 12 2018, 7:25 PM
Closed by commit rL325026: Include <sys/time.h> to get struct timeval definition (authored by dim). · Explain WhyFeb 13 2018, 9:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
MultiSource/
Benchmarks/
DOE-ProxyApps-C++/
CLAMR/
1 line

Diff 133796

MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMR/partition.cpp

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
* David Nicholaeff dnic@lanl.gov, mtrxknight@aol.com * David Nicholaeff dnic@lanl.gov, mtrxknight@aol.com
* Dennis Trujillo dptrujillo@lanl.gov, dptru10@gmail.com * Dennis Trujillo dptrujillo@lanl.gov, dptru10@gmail.com
* *
*/ */
#ifdef HAVE_MPI #ifdef HAVE_MPI
#include "mpi.h" #include "mpi.h"
#endif #endif
#include <sys/time.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <math.h> #include <math.h>
#include <list> #include <list>
#include <algorithm> #include <algorithm>
#include "partition.h" #include "partition.h"
#include "KDTree.h" #include "KDTree.h"
#include "mesh.h" #include "mesh.h"
▲ Show 20 Lines • Show All 697 Lines • Show Last 20 Lines