This is an archive of the discontinued LLVM Phabricator instance.

Fix test clang-diff-json.cpp
ClosedPublic

Authored by asmith on Feb 10 2018, 12:16 PM.

Download Raw Diff

Details

Reviewers

zturner
llvm-commits

Commits

rG51a6fc6fec60: Fix test clang-diff-json.cpp
rL324824: Fix test clang-diff-json.cpp
rC324824: Fix test clang-diff-json.cpp

Summary

This test would fail if the python path had spaces. Add a quote around the path to fix this problem and update some test values changed by the addition of quotes around the path.

Tested on Windows and Linux with Python 3.x

Diff Detail

Repository: rC Clang

Event Timeline

asmith created this revision.Feb 10 2018, 12:16 PM

Herald added subscribers: cfe-commits, klimek. · View Herald TranscriptFeb 10 2018, 12:16 PM

asmith retitled this revision from Fix test from failing when the python path has spaces to Fix test clang-diff-json.cpp.Feb 10 2018, 12:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 10 2018, 1:33 PM

Closed by commit rC324824: Fix test clang-diff-json.cpp (authored by asmith). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

test/

Tooling/

clang-diff-json.cpp

6 lines

Diff 133768

test/Tooling/clang-diff-json.cpp

	// RUN: clang-diff -ast-dump-json %s -- \			// RUN: clang-diff -ast-dump-json %s -- \
	// RUN: \| %python -c 'import json, sys; json.dump(json.loads(sys.stdin.read()), sys.stdout, sort_keys=True, indent=2)' \			// RUN: \| '%python' -c 'import json, sys; json.dump(json.loads(sys.stdin.read()), sys.stdout, sort_keys=True, indent=2)' \
	// RUN: \| FileCheck %s			// RUN: \| FileCheck %s

	// CHECK: "begin": 299,			// CHECK: "begin": 301,
	// CHECK: "type": "FieldDecl",			// CHECK: "type": "FieldDecl",
	// CHECK: "end": 319,			// CHECK: "end": 321,
	// CHECK: "type": "CXXRecordDecl",			// CHECK: "type": "CXXRecordDecl",
	class A {			class A {
	int x;			int x;
	};			};

	// CHECK: "children": [			// CHECK: "children": [
	// CHECK-NEXT: {			// CHECK-NEXT: {
	// CHECK-NEXT: "begin":			// CHECK-NEXT: "begin":
	Show All 12 Lines