Some comments, but mainly I'm just bewildered by tablegen.
|3636 ↗||(On Diff #133724)|
Is it worth having a comment on this one?
|7420 ↗||(On Diff #133724)|
Can we make WithStride a bool, or is that not supported?
|7426 ↗||(On Diff #133724)|
It's sort of a nit, but: I think I see what you're trying to do with the alignment of # under the paren, but it doesn't totally work for me, especially when we add a space *after* the #.
Maybe you could just pull the #s up onto the line above? Then we don't have any of these issues.
|7505 ↗||(On Diff #133724)|