This is an archive of the discontinued LLVM Phabricator instance.

Differential D43030

Update AMDGPU documentation about address space
ClosedPublic

Authored by yaxunl on Feb 7 2018, 10:36 AM.

Details

Reviewers
t-tye
b-sumner

Diff Detail

Event Timeline

yaxunl created this revision.Feb 7 2018, 10:36 AM
Herald added subscribers: tpr, dstuttard, nhaehnle and 2 others. · View Herald TranscriptFeb 7 2018, 10:36 AM
t-tye requested changes to this revision.Feb 7 2018, 11:13 AM
t-tye added inline comments.
docs/AMDGPUUsage.rst
68–69

Presumably this also needs updating?

This revision now requires changes to proceed.Feb 7 2018, 11:13 AM
yaxunl updated this revision to Diff 133266.Feb 7 2018, 11:34 AM

Removed amdgiz and amdgizcl.

t-tye accepted this revision.Feb 7 2018, 3:42 PM

LGTM

This revision is now accepted and ready to land.Feb 7 2018, 3:42 PM
yaxunl closed this revision.Feb 8 2018, 11:04 AM

committed.

Revision Contents

PathSize
docs/
38 lines

Diff 133266

docs/AMDGPUUsage.rst

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Linesspecify the target triple:
.. table:: AMDGPU Environments .. table:: AMDGPU Environments
:name: amdgpu-environment-table :name: amdgpu-environment-table
============ ============================================================== ============ ==============================================================
Environment Description Environment Description
============ ============================================================== ============ ==============================================================
*<empty>* Defaults to ``opencl``. *<empty>* Defaults to ``opencl``.
``opencl`` OpenCL compute kernel (see :ref:`amdgpu-opencl`). ``opencl`` OpenCL compute kernel (see :ref:`amdgpu-opencl`).
``amdgizcl`` Same as ``opencl`` except a different address space mapping is
used (see :ref:`amdgpu-address-spaces`).
``amdgiz`` Same as ``opencl`` except a different address space mapping is
used (see :ref:`amdgpu-address-spaces`).
``hcc`` AMD HC language compute kernel (see :ref:`amdgpu-hcc`). ``hcc`` AMD HC language compute kernel (see :ref:`amdgpu-hcc`).
t-tyeUnsubmitted
Not Done
ReplyInline Actions

Presumably this also needs updating?

t-tye: Presumably this also needs updating?
============ ============================================================== ============ ==============================================================
.. _amdgpu-processors: .. _amdgpu-processors:
Processors Processors
---------- ----------
Use the ``clang -mcpu <Processor>`` option to specify the AMD GPU processor. The Use the ``clang -mcpu <Processor>`` option to specify the AMD GPU processor. The
▲ Show 20 Lines • Show All 187 Lines • ▼ Show 20 Lines
The memory space names used in the table, aside from the region memory space, is The memory space names used in the table, aside from the region memory space, is
from the OpenCL standard. from the OpenCL standard.
LLVM Address Space number is used throughout LLVM (for example, in LLVM IR). LLVM Address Space number is used throughout LLVM (for example, in LLVM IR).
.. table:: Address Space Mapping .. table:: Address Space Mapping
:name: amdgpu-address-space-mapping-table :name: amdgpu-address-space-mapping-table
================== ================= ================= ================= ================= ================== ================= =================
LLVM Address Space Memory Space LLVM Address Space Memory Space
------------------ ----------------------------------------------------------------------- ------------------ -----------------------------------
\ Current Default amdgiz/amdgizcl hcc Future Default \ Current Default Future Default
================== ================= ================= ================= ================= ================== ================= =================
0 Private (Scratch) Generic (Flat) Generic (Flat) Generic (Flat) 0 Generic (Flat) Generic (Flat)
1 Global Global Global Global 1 Global Global
2 Constant Constant Constant Region (GDS) 2 Constant Region (GDS)
3 Local (group/LDS) Local (group/LDS) Local (group/LDS) Local (group/LDS) 3 Local (group/LDS) Local (group/LDS)
4 Generic (Flat) Region (GDS) Region (GDS) Constant 4 Region (GDS) Constant
5 Region (GDS) Private (Scratch) Private (Scratch) Private (Scratch) 5 Private (Scratch) Private (Scratch)
================== ================= ================= ================= ================= ================== ================= =================
Current Default Current Default
This is the current default address space mapping used for all languages This is the current default address space mapping used for all languages.
except hcc. This will shortly be deprecated. This will shortly be deprecated.
amdgiz/amdgizcl
This is the current address space mapping used when ``amdgiz`` or ``amdgizcl``
is specified as the target triple environment value.
hcc
This is the current address space mapping used when ``hcc`` is specified as
the target triple environment value.This will shortly be deprecated.
Future Default Future Default
This will shortly be the only address space mapping for all languages using This will shortly be the only address space mapping for all languages using
AMDGPU backend. AMDGPU backend.
.. _amdgpu-memory-scopes: .. _amdgpu-memory-scopes:
Memory Scopes Memory Scopes
▲ Show 20 Lines • Show All 992 Lines • Show Last 20 Lines