Page MenuHomePhabricator

[test] Enable test category for inline tests.
ClosedPublic

Authored by JDevlieghere on Feb 7 2018, 8:08 AM.

Details

Summary

Inlined tests have a test function that is actually an instance method,
which requires a slightly different approach when it comes to setting
the category attribute. The attribute must be set on the actual
function, rather than on a particular instance.

Diff Detail

Event Timeline

JDevlieghere created this revision.Feb 7 2018, 8:08 AM
davide accepted this revision.Feb 7 2018, 8:10 AM

thanks for fixing this.

lldb/packages/Python/lldbsuite/test/decorators.py
529

We should consider clang-formatting this file altogether.

This revision is now accepted and ready to land.Feb 7 2018, 8:10 AM
JDevlieghere closed this revision.Feb 7 2018, 8:13 AM

Forgot to add the differential to the commit message. Landed in rL324488

labath added inline comments.Feb 7 2018, 8:15 AM
lldb/packages/Python/lldbsuite/test/decorators.py
306–307

These two lines look like they need to be fixed as well.

529

The current (weird) formatting is the result of running autopep8 as a part of the huge refactor some time ago...

The change in r324488 dropped the existing category attribute in for
instance methods. This patch corrects that.

vsk reopened this revision.Feb 7 2018, 10:55 AM

Ah, I see the first part landed in rL324488 and this is a follow-up.

This revision is now accepted and ready to land.Feb 7 2018, 10:55 AM
vsk accepted this revision.Feb 7 2018, 10:55 AM

This lgtm Jonas, thank you!

JDevlieghere closed this revision.Feb 7 2018, 1:57 PM

Jup. Sorry for making it so confusing. Because Pavel's reply was here it seemed sensible to update the diff.

Landed in rL324492