This is an archive of the discontinued LLVM Phabricator instance.

Differential D42974

[SROA] Take advantage of separate alignments for memcpy source and destination
ClosedPublic

Authored by dneilson on Feb 6 2018, 10:46 AM.

Details

Reviewers
chandlerc
bollu
efriedma
Commits
rG41e781d5f153: [SROA] Take advantage of separate alignments for memcpy source and destination
rL327398: [SROA] Take advantage of separate alignments for memcpy source and destination
Summary

This change is part of step five in the series of changes to remove alignment argument from
memcpy/memmove/memset in favour of alignment attributes. In particular, this changes the
SROA pass to cease using the old getAlignment() & setAlignment() APIs of MemoryIntrinsic in
favour of getting source & dest specific alignments through the new API. This allows us
to enhance visitMemTransferInst to be more aggressive setting the alignment in memcpy
calls that it creates, as well as to only change the alignment of a memcpy/memmove
argument that it replaces.

Steps:
Step 1) Remove alignment parameter and create alignment parameter attributes for
memcpy/memmove/memset. ( rL322965, rC322964, rL322963 )
Step 2) Expand the IRBuilder API to allow creation of memcpy/memmove with differing
source and dest alignments. ( rL323597 )
Step 3) Update Clang to use the new IRBuilder API. ( rC323617 )
Step 4) Update Polly to use the new IRBuilder API. ( rL323618 )
Step 5) Update LLVM passes that create memcpy/memmove calls to use the new IRBuilder API,
and those that use use MemIntrinsicInst::[get|set]Alignment() to use [get|set]DestAlignment()
and [get|set]SourceAlignment() instead. ( rL323886, rL323891, rL324148, rL324273 )
Step 6) Remove the single-alignment IRBuilder API for memcpy/memmove, and the
MemIntrinsicInst::[get|set]Alignment() methods.

Reference

http://lists.llvm.org/pipermail/llvm-dev/2015-August/089384.html
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151109/312083.html

Diff Detail

Event Timeline

dneilson created this revision.Feb 6 2018, 10:46 AM
Herald added a reviewer: bollu. · View Herald TranscriptFeb 6 2018, 10:46 AM
Herald added a subscriber: eraman. · View Herald Transcript
Harbormaster completed remote builds in B14671: Diff 133041.Feb 6 2018, 10:47 AM
dneilson added a comment.Feb 12 2018, 6:49 AM

ping

dneilson updated this revision to Diff 135460.Feb 22 2018, 10:11 AM
  • Rebaseline
dneilson added a comment.Feb 28 2018, 11:59 AM

ping

dneilson added a comment.Mar 12 2018, 1:35 PM

ping. Anyone able to review?

efriedma added a reviewer: efriedma.Mar 12 2018, 2:02 PM
efriedma added a subscriber: efriedma.
efriedma added inline comments.
lib/Transforms/Scalar/SROA.cpp
2701

Testcase?

2828

Testcase? (At least, at first glance it doesn't look like the memcpy tests cover this.)

2899

All the checks for IsDest here are confusing... could you make explicit variables SrcPtr/DstPtr/SrcAlign/DstAlign?

dneilson added a comment.Mar 12 2018, 2:49 PM

Thank you for taking a look at this Eli! Very much appreciated

lib/Transforms/Scalar/SROA.cpp
2701

Any number of the memsets in tests/Transforms/SROA/basictest.ll act as a test for this. For example, the memset in test18 at line 783.

2828

test18 -- the memcpy at line 798 tests the IsDest case
test18 -- the memcpy at line 803 tests the !IsDest case

There are others as well; this is just a sampling.

2899

Fair point.. I completely agree. I'll get a revision up shortly.

efriedma added inline comments.Mar 12 2018, 2:56 PM
lib/Transforms/Scalar/SROA.cpp
2701

This isn't actually a functional change; nevermind.

2828

Okay. It would be nice to have a test which explicitly checks we preserve the alignment on the other operand.

dneilson added inline comments.Mar 12 2018, 3:06 PM
lib/Transforms/Scalar/SROA.cpp
2828

Those same memcpys end up testing both; that's why the test case change in test18 is as it is in this patch. I'll annotate the lines in the test below...

test/Transforms/SROA/basictest.ll
83

FYI - the alignment on the %src arg here was changed to force some variety in the alignments on memcpys that are created in this test.

781

This is the IsDest case for !IsSplittable

790

This is the !IsDest case for !IsSplittable

dneilson updated this revision to Diff 138096.Mar 12 2018, 3:08 PM

Rebaseline & address review comment regarding reducing the usage of ternary operator
in creation of memcpy.

efriedma accepted this revision.Mar 12 2018, 3:34 PM

LGTM

This revision is now accepted and ready to land.Mar 12 2018, 3:34 PM
Closed by commit rL327398: [SROA] Take advantage of separate alignments for memcpy source and destination (authored by dneilson). · Explain WhyMar 13 2018, 7:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Transforms/
Scalar/
23 lines
test/
Transforms/
SROA/
18 lines

Diff 135460

lib/Transforms/Scalar/SROA.cpp

Show First 20 Lines • Show All 2,692 Lines • ▼ Show 20 Lines bool visitMemSetInst(MemSetInst &II) {
II.getAAMetadata(AATags); II.getAAMetadata(AATags);
// If the memset has a variable size, it cannot be split, just adjust the // If the memset has a variable size, it cannot be split, just adjust the
// pointer to the new alloca. // pointer to the new alloca.
if (!isa<Constant>(II.getLength())) { if (!isa<Constant>(II.getLength())) {
assert(!IsSplit); assert(!IsSplit);
assert(NewBeginOffset == BeginOffset); assert(NewBeginOffset == BeginOffset);
II.setDest(getNewAllocaSlicePtr(IRB, OldPtr->getType())); II.setDest(getNewAllocaSlicePtr(IRB, OldPtr->getType()));
II.setAlignment(getSliceAlign()); II.setDestAlignment(getSliceAlign());
efriedmaUnsubmitted
Not Done
ReplyInline Actions

Testcase?

efriedma: Testcase?
dneilsonAuthorUnsubmitted
Not Done
ReplyInline Actions

Any number of the memsets in tests/Transforms/SROA/basictest.ll act as a test for this. For example, the memset in test18 at line 783.

dneilson: Any number of the memsets in tests/Transforms/SROA/basictest.ll act as a test for this. For…
efriedmaUnsubmitted
Not Done
ReplyInline Actions

This isn't actually a functional change; nevermind.

efriedma: This isn't actually a functional change; nevermind.
deleteIfTriviallyDead(OldPtr); deleteIfTriviallyDead(OldPtr);
return false; return false;
} }
// Record this instruction for deletion. // Record this instruction for deletion.
Pass.DeadInsts.insert(&II); Pass.DeadInsts.insert(&II);
▲ Show 20 Lines • Show All 104 Lines • ▼ Show 20 Lines bool visitMemTransferInst(MemTransferInst &II) {
// pointers in place. This isn't just an optimization, it is a matter of // pointers in place. This isn't just an optimization, it is a matter of
// correctness. With unsplit intrinsics we may be dealing with transfers // correctness. With unsplit intrinsics we may be dealing with transfers
// within a single alloca before SROA ran, or with transfers that have // within a single alloca before SROA ran, or with transfers that have
// a variable length. We may also be dealing with memmove instead of // a variable length. We may also be dealing with memmove instead of
// memcpy, and so simply updating the pointers is the necessary for us to // memcpy, and so simply updating the pointers is the necessary for us to
// update both source and dest of a single call. // update both source and dest of a single call.
if (!IsSplittable) { if (!IsSplittable) {
Value *AdjustedPtr = getNewAllocaSlicePtr(IRB, OldPtr->getType()); Value *AdjustedPtr = getNewAllocaSlicePtr(IRB, OldPtr->getType());
if (IsDest) if (IsDest) {
II.setDest(AdjustedPtr); II.setDest(AdjustedPtr);
else II.setDestAlignment(SliceAlign);
}
else {
II.setSource(AdjustedPtr); II.setSource(AdjustedPtr);
II.setSourceAlignment(SliceAlign);
efriedmaUnsubmitted
Not Done
ReplyInline Actions

Testcase? (At least, at first glance it doesn't look like the memcpy tests cover this.)

efriedma: Testcase? (At least, at first glance it doesn't look like the memcpy tests cover this.)
dneilsonAuthorUnsubmitted
Not Done
ReplyInline Actions

test18 -- the memcpy at line 798 tests the IsDest case
test18 -- the memcpy at line 803 tests the !IsDest case

There are others as well; this is just a sampling.

dneilson: test18 -- the memcpy at line 798 tests the IsDest case test18 -- the memcpy at line 803 tests…
efriedmaUnsubmitted
Not Done
ReplyInline Actions

Okay. It would be nice to have a test which explicitly checks we preserve the alignment on the other operand.

efriedma: Okay. It would be nice to have a test which explicitly checks we preserve the alignment on the…
dneilsonAuthorUnsubmitted
Not Done
ReplyInline Actions

Those same memcpys end up testing both; that's why the test case change in test18 is as it is in this patch. I'll annotate the lines in the test below...

dneilson: Those same memcpys end up testing both; that's why the test case change in test18 is as it is…
if (II.getAlignment() > SliceAlign) {
II.setAlignment(MinAlign(II.getAlignment(), SliceAlign));
} }
DEBUG(dbgs() << " to: " << II << "\n"); DEBUG(dbgs() << " to: " << II << "\n");
deleteIfTriviallyDead(OldPtr); deleteIfTriviallyDead(OldPtr);
return false; return false;
} }
// For split transfer intrinsics we have an incredibly useful assurance: // For split transfer intrinsics we have an incredibly useful assurance:
// the source and destination do not reside within the same alloca, and at // the source and destination do not reside within the same alloca, and at
Show All 36 Lines bool visitMemTransferInst(MemTransferInst &II) {
} }
Type *OtherPtrTy = OtherPtr->getType(); Type *OtherPtrTy = OtherPtr->getType();
unsigned OtherAS = OtherPtrTy->getPointerAddressSpace(); unsigned OtherAS = OtherPtrTy->getPointerAddressSpace();
// Compute the relative offset for the other pointer within the transfer. // Compute the relative offset for the other pointer within the transfer.
unsigned IntPtrWidth = DL.getPointerSizeInBits(OtherAS); unsigned IntPtrWidth = DL.getPointerSizeInBits(OtherAS);
APInt OtherOffset(IntPtrWidth, NewBeginOffset - BeginOffset); APInt OtherOffset(IntPtrWidth, NewBeginOffset - BeginOffset);
unsigned OtherAlign = MinAlign(II.getAlignment() ? II.getAlignment() : 1, unsigned OtherAlign =
IsDest ? II.getSourceAlignment() : II.getDestAlignment();
OtherAlign = MinAlign(OtherAlign ? OtherAlign : 1,
OtherOffset.zextOrTrunc(64).getZExtValue()); OtherOffset.zextOrTrunc(64).getZExtValue());
if (EmitMemCpy) { if (EmitMemCpy) {
// Compute the other pointer, folding as much as possible to produce // Compute the other pointer, folding as much as possible to produce
// a single, simple GEP in most cases. // a single, simple GEP in most cases.
OtherPtr = getAdjustedPtr(IRB, DL, OtherPtr, OtherOffset, OtherPtrTy, OtherPtr = getAdjustedPtr(IRB, DL, OtherPtr, OtherOffset, OtherPtrTy,
OtherPtr->getName() + "."); OtherPtr->getName() + ".");
Value *OurPtr = getNewAllocaSlicePtr(IRB, OldPtr->getType()); Value *OurPtr = getNewAllocaSlicePtr(IRB, OldPtr->getType());
Type *SizeTy = II.getLength()->getType(); Type *SizeTy = II.getLength()->getType();
Constant *Size = ConstantInt::get(SizeTy, NewEndOffset - NewBeginOffset); Constant *Size = ConstantInt::get(SizeTy, NewEndOffset - NewBeginOffset);
CallInst *New = IRB.CreateMemCpy( CallInst *New = IRB.CreateMemCpy(
IsDest ? OurPtr : OtherPtr, IsDest ? OtherPtr : OurPtr, Size, IsDest ? OurPtr : OtherPtr, IsDest ? SliceAlign : OtherAlign,
MinAlign(SliceAlign, OtherAlign), II.isVolatile()); IsDest ? OtherPtr : OurPtr, IsDest ? OtherAlign : SliceAlign,
Size, II.isVolatile());
efriedmaUnsubmitted
Not Done
ReplyInline Actions

All the checks for IsDest here are confusing... could you make explicit variables SrcPtr/DstPtr/SrcAlign/DstAlign?

efriedma: All the checks for IsDest here are confusing... could you make explicit variables…
dneilsonAuthorUnsubmitted
Not Done
ReplyInline Actions

Fair point.. I completely agree. I'll get a revision up shortly.

dneilson: Fair point.. I completely agree. I'll get a revision up shortly.
if (AATags) if (AATags)
New->setAAMetadata(AATags); New->setAAMetadata(AATags);
DEBUG(dbgs() << " to: " << *New << "\n"); DEBUG(dbgs() << " to: " << *New << "\n");
return false; return false;
} }
bool IsWholeAlloca = NewBeginOffset == NewAllocaBeginOffset && bool IsWholeAlloca = NewBeginOffset == NewAllocaBeginOffset &&
NewEndOffset == NewAllocaEndOffset; NewEndOffset == NewAllocaEndOffset;
▲ Show 20 Lines • Show All 1,574 Lines • Show Last 20 Lines

test/Transforms/SROA/basictest.ll

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Linesentry:
store i64 %X, i64* %B store i64 %X, i64* %B
br label %L2 br label %L2
L2: L2:
%Z = load i64, i64* %B %Z = load i64, i64* %B
ret i64 %Z ret i64 %Z
} }
define void @test3(i8* %dst, i8* %src) { define void @test3(i8* %dst, i8* align 8 %src) {
; CHECK-LABEL: @test3( ; CHECK-LABEL: @test3(
entry: entry:
%a = alloca [300 x i8] %a = alloca [300 x i8]
; CHECK-NOT: alloca ; CHECK-NOT: alloca
; CHECK: %[[test3_a1:.*]] = alloca [42 x i8] ; CHECK: %[[test3_a1:.*]] = alloca [42 x i8]
; CHECK-NEXT: %[[test3_a2:.*]] = alloca [99 x i8] ; CHECK-NEXT: %[[test3_a2:.*]] = alloca [99 x i8]
; CHECK-NEXT: %[[test3_a3:.*]] = alloca [16 x i8] ; CHECK-NEXT: %[[test3_a3:.*]] = alloca [16 x i8]
; CHECK-NEXT: %[[test3_a4:.*]] = alloca [42 x i8] ; CHECK-NEXT: %[[test3_a4:.*]] = alloca [42 x i8]
; CHECK-NEXT: %[[test3_a5:.*]] = alloca [7 x i8] ; CHECK-NEXT: %[[test3_a5:.*]] = alloca [7 x i8]
; CHECK-NEXT: %[[test3_a6:.*]] = alloca [7 x i8] ; CHECK-NEXT: %[[test3_a6:.*]] = alloca [7 x i8]
; CHECK-NEXT: %[[test3_a7:.*]] = alloca [85 x i8] ; CHECK-NEXT: %[[test3_a7:.*]] = alloca [85 x i8]
%b = getelementptr [300 x i8], [300 x i8]* %a, i64 0, i64 0 %b = getelementptr [300 x i8], [300 x i8]* %a, i64 0, i64 0
call void @llvm.memcpy.p0i8.p0i8.i32(i8* %b, i8* %src, i32 300, i1 false), !tbaa !0 call void @llvm.memcpy.p0i8.p0i8.i32(i8* %b, i8* align 8 %src, i32 300, i1 false), !tbaa !0
dneilsonAuthorUnsubmitted
Not Done
ReplyInline Actions

FYI - the alignment on the %src arg here was changed to force some variety in the alignments on memcpys that are created in this test.

dneilson: FYI - the alignment on the %src arg here was changed to force some variety in the alignments on…
; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [42 x i8], [42 x i8]* %[[test3_a1]], i64 0, i64 0 ; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [42 x i8], [42 x i8]* %[[test3_a1]], i64 0, i64 0
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 1 %src, i32 42, {{.*}}), !tbaa [[TAG_0:!.*]] ; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 8 %src, i32 42, {{.*}}), !tbaa [[TAG_0:!.*]]
; CHECK-NEXT: %[[gep:.*]] = getelementptr inbounds i8, i8* %src, i64 42 ; CHECK-NEXT: %[[gep:.*]] = getelementptr inbounds i8, i8* %src, i64 42
; CHECK-NEXT: %[[test3_r1:.*]] = load i8, i8* %[[gep]], {{.*}}, !tbaa [[TAG_0]] ; CHECK-NEXT: %[[test3_r1:.*]] = load i8, i8* %[[gep]], {{.*}}, !tbaa [[TAG_0]]
; CHECK-NEXT: %[[gep_src:.*]] = getelementptr inbounds i8, i8* %src, i64 43 ; CHECK-NEXT: %[[gep_src:.*]] = getelementptr inbounds i8, i8* %src, i64 43
; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [99 x i8], [99 x i8]* %[[test3_a2]], i64 0, i64 0 ; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [99 x i8], [99 x i8]* %[[test3_a2]], i64 0, i64 0
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 1 %[[gep_src]], i32 99, {{.*}}), !tbaa [[TAG_0:!.*]] ; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 1 %[[gep_src]], i32 99, {{.*}}), !tbaa [[TAG_0:!.*]]
; CHECK-NEXT: %[[gep_src:.*]] = getelementptr inbounds i8, i8* %src, i64 142 ; CHECK-NEXT: %[[gep_src:.*]] = getelementptr inbounds i8, i8* %src, i64 142
; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [16 x i8], [16 x i8]* %[[test3_a3]], i64 0, i64 0 ; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [16 x i8], [16 x i8]* %[[test3_a3]], i64 0, i64 0
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 1 %[[gep_src]], i32 16, {{.*}}), !tbaa [[TAG_0:!.*]] ; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 2 %[[gep_src]], i32 16, {{.*}}), !tbaa [[TAG_0:!.*]]
; CHECK-NEXT: %[[gep_src:.*]] = getelementptr inbounds i8, i8* %src, i64 158 ; CHECK-NEXT: %[[gep_src:.*]] = getelementptr inbounds i8, i8* %src, i64 158
; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [42 x i8], [42 x i8]* %[[test3_a4]], i64 0, i64 0 ; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [42 x i8], [42 x i8]* %[[test3_a4]], i64 0, i64 0
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 1 %[[gep_src]], i32 42, {{.*}}), !tbaa [[TAG_0:!.*]] ; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 2 %[[gep_src]], i32 42, {{.*}}), !tbaa [[TAG_0:!.*]]
; CHECK-NEXT: %[[gep_src:.*]] = getelementptr inbounds i8, i8* %src, i64 200 ; CHECK-NEXT: %[[gep_src:.*]] = getelementptr inbounds i8, i8* %src, i64 200
; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [7 x i8], [7 x i8]* %[[test3_a5]], i64 0, i64 0 ; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [7 x i8], [7 x i8]* %[[test3_a5]], i64 0, i64 0
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 1 %[[gep_src]], i32 7, {{.*}}), !tbaa [[TAG_0:!.*]] ; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 8 %[[gep_src]], i32 7, {{.*}}), !tbaa [[TAG_0:!.*]]
; CHECK-NEXT: %[[gep:.*]] = getelementptr inbounds i8, i8* %src, i64 207 ; CHECK-NEXT: %[[gep:.*]] = getelementptr inbounds i8, i8* %src, i64 207
; CHECK-NEXT: %[[test3_r2:.*]] = load i8, i8* %[[gep]], {{.*}}, !tbaa [[TAG_0]] ; CHECK-NEXT: %[[test3_r2:.*]] = load i8, i8* %[[gep]], {{.*}}, !tbaa [[TAG_0]]
; CHECK-NEXT: %[[gep_src:.*]] = getelementptr inbounds i8, i8* %src, i64 208 ; CHECK-NEXT: %[[gep_src:.*]] = getelementptr inbounds i8, i8* %src, i64 208
; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [7 x i8], [7 x i8]* %[[test3_a6]], i64 0, i64 0 ; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [7 x i8], [7 x i8]* %[[test3_a6]], i64 0, i64 0
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 1 %[[gep_src]], i32 7, {{.*}}), !tbaa [[TAG_0:!.*]] ; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 8 %[[gep_src]], i32 7, {{.*}}), !tbaa [[TAG_0:!.*]]
; CHECK-NEXT: %[[gep_src:.*]] = getelementptr inbounds i8, i8* %src, i64 215 ; CHECK-NEXT: %[[gep_src:.*]] = getelementptr inbounds i8, i8* %src, i64 215
; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [85 x i8], [85 x i8]* %[[test3_a7]], i64 0, i64 0 ; CHECK-NEXT: %[[gep_dst:.*]] = getelementptr inbounds [85 x i8], [85 x i8]* %[[test3_a7]], i64 0, i64 0
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 1 %[[gep_src]], i32 85, {{.*}}), !tbaa [[TAG_0:!.*]] ; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[gep_dst]], i8* align 1 %[[gep_src]], i32 85, {{.*}}), !tbaa [[TAG_0:!.*]]
; Clobber a single element of the array, this should be promotable, and be deleted. ; Clobber a single element of the array, this should be promotable, and be deleted.
%c = getelementptr [300 x i8], [300 x i8]* %a, i64 0, i64 42 %c = getelementptr [300 x i8], [300 x i8]* %a, i64 0, i64 42
store i8 0, i8* %c store i8 0, i8* %c
▲ Show 20 Lines • Show All 660 Lines • ▼ Show 20 Lines
; fixed size operations. Further, continue to split and promote allocas preceding ; fixed size operations. Further, continue to split and promote allocas preceding
; the variable sized intrinsic. ; the variable sized intrinsic.
; CHECK-LABEL: @test18( ; CHECK-LABEL: @test18(
; CHECK: %[[a:.*]] = alloca [34 x i8] ; CHECK: %[[a:.*]] = alloca [34 x i8]
; CHECK: %[[srcgep1:.*]] = getelementptr inbounds i8, i8* %src, i64 4 ; CHECK: %[[srcgep1:.*]] = getelementptr inbounds i8, i8* %src, i64 4
; CHECK-NEXT: %[[srccast1:.*]] = bitcast i8* %[[srcgep1]] to i32* ; CHECK-NEXT: %[[srccast1:.*]] = bitcast i8* %[[srcgep1]] to i32*
; CHECK-NEXT: %[[srcload:.*]] = load i32, i32* %[[srccast1]], {{.*}}, !tbaa [[TAG_0]] ; CHECK-NEXT: %[[srcload:.*]] = load i32, i32* %[[srccast1]], {{.*}}, !tbaa [[TAG_0]]
; CHECK-NEXT: %[[agep1:.*]] = getelementptr inbounds [34 x i8], [34 x i8]* %[[a]], i64 0, i64 0 ; CHECK-NEXT: %[[agep1:.*]] = getelementptr inbounds [34 x i8], [34 x i8]* %[[a]], i64 0, i64 0
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* %[[agep1]], i8* %src, i32 %size, {{.*}}), !tbaa [[TAG_3]] ; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %[[agep1]], i8* %src, i32 %size, {{.*}}), !tbaa [[TAG_3]]
dneilsonAuthorUnsubmitted
Not Done
ReplyInline Actions

This is the IsDest case for !IsSplittable

dneilson: This is the IsDest case for !IsSplittable
; CHECK-NEXT: %[[agep2:.*]] = getelementptr inbounds [34 x i8], [34 x i8]* %[[a]], i64 0, i64 0 ; CHECK-NEXT: %[[agep2:.*]] = getelementptr inbounds [34 x i8], [34 x i8]* %[[a]], i64 0, i64 0
; CHECK-NEXT: call void @llvm.memset.p0i8.i32(i8* align 1 %[[agep2]], i8 42, i32 %size, {{.*}}), !tbaa [[TAG_5]] ; CHECK-NEXT: call void @llvm.memset.p0i8.i32(i8* align 1 %[[agep2]], i8 42, i32 %size, {{.*}}), !tbaa [[TAG_5]]
; CHECK-NEXT: %[[dstcast1:.*]] = bitcast i8* %dst to i32* ; CHECK-NEXT: %[[dstcast1:.*]] = bitcast i8* %dst to i32*
; CHECK-NEXT: store i32 42, i32* %[[dstcast1]], {{.*}}, !tbaa [[TAG_9]] ; CHECK-NEXT: store i32 42, i32* %[[dstcast1]], {{.*}}, !tbaa [[TAG_9]]
; CHECK-NEXT: %[[dstgep1:.*]] = getelementptr inbounds i8, i8* %dst, i64 4 ; CHECK-NEXT: %[[dstgep1:.*]] = getelementptr inbounds i8, i8* %dst, i64 4
; CHECK-NEXT: %[[dstcast2:.*]] = bitcast i8* %[[dstgep1]] to i32* ; CHECK-NEXT: %[[dstcast2:.*]] = bitcast i8* %[[dstgep1]] to i32*
; CHECK-NEXT: store i32 %[[srcload]], i32* %[[dstcast2]], {{.*}}, !tbaa [[TAG_9]] ; CHECK-NEXT: store i32 %[[srcload]], i32* %[[dstcast2]], {{.*}}, !tbaa [[TAG_9]]
; CHECK-NEXT: %[[agep3:.*]] = getelementptr inbounds [34 x i8], [34 x i8]* %[[a]], i64 0, i64 0 ; CHECK-NEXT: %[[agep3:.*]] = getelementptr inbounds [34 x i8], [34 x i8]* %[[a]], i64 0, i64 0
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* %dst, i8* %[[agep3]], i32 %size, {{.*}}), !tbaa [[TAG_11]] ; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* %dst, i8* align 1 %[[agep3]], i32 %size, {{.*}}), !tbaa [[TAG_11]]
dneilsonAuthorUnsubmitted
Not Done
ReplyInline Actions

This is the !IsDest case for !IsSplittable

dneilson: This is the !IsDest case for !IsSplittable
; CHECK-NEXT: ret void ; CHECK-NEXT: ret void
entry: entry:
%a = alloca [42 x i8] %a = alloca [42 x i8]
%ptr = getelementptr [42 x i8], [42 x i8]* %a, i32 0, i32 0 %ptr = getelementptr [42 x i8], [42 x i8]* %a, i32 0, i32 0
call void @llvm.memcpy.p0i8.p0i8.i32(i8* %ptr, i8* %src, i32 8, i1 false), !tbaa !0 call void @llvm.memcpy.p0i8.p0i8.i32(i8* %ptr, i8* %src, i32 8, i1 false), !tbaa !0
%ptr2 = getelementptr [42 x i8], [42 x i8]* %a, i32 0, i32 8 %ptr2 = getelementptr [42 x i8], [42 x i8]* %a, i32 0, i32 8
call void @llvm.memcpy.p0i8.p0i8.i32(i8* %ptr2, i8* %src, i32 %size, i1 false), !tbaa !3 call void @llvm.memcpy.p0i8.p0i8.i32(i8* %ptr2, i8* %src, i32 %size, i1 false), !tbaa !3
▲ Show 20 Lines • Show All 1,071 Lines • Show Last 20 Lines