|5467 ↗||(On Diff #132999)|
Maybe rename this to ReferenceDllExportedMembers now that it applies to variables as well.
|5482 ↗||(On Diff #132999)|
Let's move the MD part down until where it's used.
|5485 ↗||(On Diff #132999)|
The intendation looks off here. Can you run it through clang-format maybe? It would also be good with a comment explaining why the code is here.
|5487 ↗||(On Diff #132999)|
Does the 'const' really make a difference for whether the member should be exported?
|1 ↗||(On Diff #132999)|
This test doesn't seem to have any "RUN" line, which means nothing actually gets tested.
Can you add a case to test/CodeGenCXX/dllexport.cpp instead?
Thanks! Just a few more comments.
|5500 ↗||(On Diff #133498)|
Since VD is a class member, I think isDefinedOutsideFunctionOrMethod() is always true and not interesting to check.
|571 ↗||(On Diff #133498)|
Can you move this check down where the class etc. are declared below? Maybe also add a comment explaining what it's testing and reference the bug number.
|985 ↗||(On Diff #133498)|
No need for the semicolon in the empty function, here and below. The rest of the file doesn't use this style.