This is an archive of the discontinued LLVM Phabricator instance.

Create a VSIX Installer for the VS Integration
AbandonedPublic

Authored by zturner on Jan 31 2018, 4:22 PM.

Details

Summary

This creates a simple VSIX Installer that installs into VS 2015 and VS 2017. To build this VSIX you must be using VS 2017. It can't be built with VS 2015. This is because VS 2017 introduced the ability to create VSIX's that install outside of the local extensions folder, which is necessary for us to install a toolset. See https://docs.microsoft.com/en-us/visualstudio/extensibility/set-install-root for more information.

Diff Detail

Event Timeline

zturner created this revision.Jan 31 2018, 4:22 PM
zturner updated this revision to Diff 132296.Jan 31 2018, 4:46 PM

I made a few minor changes in this update.

  1. Instead of duplicating Toolset.targets in both the x86 and x64 platform folders, have a common one at the top level that both of them import. They're actually completely identical.
  1. Rename Clang.Cpp.* to LLVM.Cpp.*. The reason being that eventually we will integrate LLD, and this is more than just clang.
  1. Removed a dead file AssemblyInfo.cs which the IDE adds by default, but isn't necessary for us since we don't actually have any code.
  1. Added some newlines at the end of files that didn't have them (don't really want to mess with the .cs file since it's auto generated, and the IDE will just keep deleting the newline every time you do something to the file)
zturner updated this revision to Diff 132303.Jan 31 2018, 5:49 PM
zturner added reviewers: smeenai, compnerd.

This update brings a couple of minor tweaks.

  1. Now, instead of just saying "Clang for Windows" in the toolchain selector, it will show you the version number. So for example it will say "Clang for Windows 7".
  1. I realized we didn't need this LLVM.props file to set the toolchain name strings, we could do it directly in our own props file. So that logic is moved there and the unnecessary file is deleted.
hans added inline comments.Feb 1 2018, 2:28 AM
llvm/tools/msbuild/install.bat
9

Oh I see, this is based on top off D42762 which isn't landed yet. I'll review that first then :-)

llvm/tools/msbuild/uninstall.bat
8

I thought we also wanted to support VS 2015?

15

Does this need quotes? Same for the SET in the next section.

zturner abandoned this revision.Feb 2 2018, 1:07 PM

This was merged into D42762