This is an archive of the discontinued LLVM Phabricator instance.

[mips] Added additional test cases for passing -mabi to the assembler.
ClosedPublic

Authored by dsanders on Jun 24 2014, 6:17 AM.

Details

Summary

This patch adds minimal coverage for each -mcpu value to ensure that none of them can pass an empty string in -mabi.

Prior to r212176, many -mcpu values would trigger this.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 10784.Jun 24 2014, 6:17 AM
dsanders retitled this revision from to [mips] Added missing CPU -> default ABI mappings..
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
atanasyan accepted this revision.Jun 24 2014, 6:59 AM
atanasyan edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jun 24 2014, 6:59 AM
vmedic accepted this revision.Jul 1 2014, 3:30 AM
vmedic edited edge metadata.

LGTM

dsanders updated this revision to Diff 11026.Jul 2 2014, 8:13 AM
dsanders edited edge metadata.

Rebasing past r212176. The functionality change has been superceded by r212176
but the test cases are still useful.

dsanders retitled this revision from [mips] Added missing CPU -> default ABI mappings. to [mips] Added additional test cases for passing -mabi to the assembler..Jul 2 2014, 8:29 AM
dsanders updated this object.
dsanders closed this revision.Jul 2 2014, 8:30 AM