This is an archive of the discontinued LLVM Phabricator instance.

[utils] De-duplicate utils/update_{llc_,}test_checks.py
ClosedPublic

Authored by MaskRay on Jan 29 2018, 12:15 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Jan 29 2018, 12:15 PM
MaskRay edited the summary of this revision. (Show Details)Jan 29 2018, 12:16 PM
MaskRay added a reviewer: spatel.
MaskRay updated this revision to Diff 131863.Jan 29 2018, 1:15 PM

Make them more similar so that easier to merge in future revision

MaskRay updated this revision to Diff 131868.Jan 29 2018, 1:38 PM

Move asm parts to UpdateTestChecks/asm.py to be reused by other scripts

echristo accepted this revision.Jan 29 2018, 2:54 PM

SGTM. Did you try running it on a file to double check that you didn't change anything? :)

This revision is now accepted and ready to land.Jan 29 2018, 2:54 PM

Unchanged

% utils/update_test_checks.py --opt-binary=~/Dev/llvm/release/bin/opt test/CodeGen/Generic/expand-experimental-reductions.ll
% utils/update_llc_test_checks.py --llc-binary=~/Dev/llvm/release/bin/llc test/CodeGen/X86/GlobalISel/gep.ll

Awesome. Do you have commit ability or do you need me to commit for you?

This revision was automatically updated to reflect the committed changes.