This is an archive of the discontinued LLVM Phabricator instance.

Move DJB hash to support. NFC
ClosedPublic

Authored by JDevlieghere on Jan 26 2018, 11:59 AM.

Details

Summary

This patch moves the DJB hash to support. It is used by dwarf for hasing
in the accelerator tables. Moving to support because we don't want to
link dsymutil against the BinaryFormat lib.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Jan 26 2018, 11:59 AM

This makes sense following the example of MD5.h

Don't you need to add it to the module map as well? Alternatively we could just stick this into MatchExtras.h/cpp.

include/llvm/Support/DJB.h
21

-> DWARF` accelerator tables.

Don't you need to add it to the module map as well?

Correct me if I'm wrong, but isn't it implicitly covered by umbrella "Support" in include/llvm/module.modulemap?

JDevlieghere marked an inline comment as done.

Added DWARF to Doxygen comment.

aprantl accepted this revision.Jan 27 2018, 8:03 AM

If the module map is using an umbrella directory, then this will automatically work. Thanks!

This revision is now accepted and ready to land.Jan 27 2018, 8:03 AM
This revision was automatically updated to reflect the committed changes.