Fix memory leaks in MinidumpParserTest

[teemperor]

Summary

We never delete the allocated RegisterContext objects, causing those tests to fail with enabled memory sanitizer.

[zturner]

Same as with the last one. For obviously correct bug fixes like this, just commit them. As an aside, make_unique will make this a bit shorter so it fits on one line. e.g. auto reg_interface = llvm::make_unique<RegisterContextLinux_x86_x64>(arch);

[teemperor]

• Using make_unique now.

unittests/Process/minidump/MinidumpParserTest.cpp

 
 TEST_F(MinidumpParserTest, ConvertMinidumpContext_x86_32) {
   SetUpData("linux-i386.dmp");
   llvm::ArrayRef<MinidumpThread> thread_list = parser->GetThreads();
   const MinidumpThread thread = thread_list[0];
   llvm::ArrayRef<uint8_t> registers(parser->GetThreadContext(thread));
 
   ArchSpec arch = parser->GetArchitecture();
-  RegisterInfoInterface *reg_interface = new RegisterContextLinux_i386(arch);
+  std::unique_ptr<RegisterInfoInterface> reg_interface(
+      new RegisterContextLinux_i386(arch));
   lldb::DataBufferSP buf =
-      ConvertMinidumpContext_x86_32(registers, reg_interface);
+      ConvertMinidumpContext_x86_32(registers, reg_interface.get());
   ASSERT_EQ(reg_interface->GetGPRSize(), buf->GetByteSize());
 
   const RegisterInfo *reg_info = reg_interface->GetRegisterInfo();
 
   std::map<uint64_t, uint32_t> reg_values;
 
   reg_values[lldb_eax_i386] = 0x00000000;
   reg_values[lldb_ebx_i386] = 0xf7778000;

 
 TEST_F(MinidumpParserTest, ConvertMinidumpContext_x86_64) {
   SetUpData("linux-x86_64.dmp");
   llvm::ArrayRef<MinidumpThread> thread_list = parser->GetThreads();
   const MinidumpThread thread = thread_list[0];
   llvm::ArrayRef<uint8_t> registers(parser->GetThreadContext(thread));
 
   ArchSpec arch = parser->GetArchitecture();
-  RegisterInfoInterface *reg_interface = new RegisterContextLinux_x86_64(arch);
+  std::unique_ptr<RegisterInfoInterface> reg_interface(
+      new RegisterContextLinux_x86_64(arch));
   lldb::DataBufferSP buf =
-      ConvertMinidumpContext_x86_64(registers, reg_interface);
+      ConvertMinidumpContext_x86_64(registers, reg_interface.get());
   ASSERT_EQ(reg_interface->GetGPRSize(), buf->GetByteSize());
 
   const RegisterInfo *reg_info = reg_interface->GetRegisterInfo();
 
   std::map<uint64_t, uint64_t> reg_values;
 
   reg_values[lldb_rax_x86_64] = 0x0000000000000000;
   reg_values[lldb_rbx_x86_64] = 0x0000000000000000;

 
 TEST_F(MinidumpParserTest, ConvertMinidumpContext_x86_32_wow64) {
   SetUpData("fizzbuzz_wow64.dmp");
   llvm::ArrayRef<MinidumpThread> thread_list = parser->GetThreads();
   const MinidumpThread thread = thread_list[0];
   llvm::ArrayRef<uint8_t> registers(parser->GetThreadContextWow64(thread));
 
   ArchSpec arch = parser->GetArchitecture();
-  RegisterInfoInterface *reg_interface = new RegisterContextLinux_i386(arch);
+  std::unique_ptr<RegisterInfoInterface> reg_interface(
+      new RegisterContextLinux_i386(arch));
   lldb::DataBufferSP buf =
-      ConvertMinidumpContext_x86_32(registers, reg_interface);
+      ConvertMinidumpContext_x86_32(registers, reg_interface.get());
   ASSERT_EQ(reg_interface->GetGPRSize(), buf->GetByteSize());
 
   const RegisterInfo *reg_info = reg_interface->GetRegisterInfo();
 
   std::map<uint64_t, uint32_t> reg_values;
 
   reg_values[lldb_eax_i386] = 0x00000000;
   reg_values[lldb_ebx_i386] = 0x0037f608;