Page MenuHomePhabricator

dvlahovski (Dimitar Vlahovski)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2016, 6:06 AM (227 w, 4 d)

Recent Activity

Sep 6 2017

dvlahovski accepted D37527: Fix for bug 34510 - Minidump target does not resolve new symbols correctly.

LGTM

Sep 6 2017, 2:59 PM

Nov 29 2016

dvlahovski accepted D27222: Remove an x86-ism from RegisterInfoInterface.

LGTM

Nov 29 2016, 2:52 PM

Nov 20 2016

dvlahovski committed rL287506: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64….
ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64…
Nov 20 2016, 1:35 PM
dvlahovski closed D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files by committing rL287506: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64….
Nov 20 2016, 1:34 PM

Nov 11 2016

dvlahovski updated the diff for D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files.

Use unique_ptr instead of shared_ptr

Nov 11 2016, 9:05 AM

Nov 10 2016

dvlahovski updated the diff for D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files.

Generated the core files with make-core.sh

Nov 10 2016, 6:47 AM
dvlahovski added a comment to D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files.

I will generate the core files with the make-core.sh script and update the revision today or tomorrow.

Nov 10 2016, 5:39 AM

Nov 4 2016

dvlahovski retitled D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files from to ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files.
Nov 4 2016, 11:07 AM

Nov 1 2016

dvlahovski committed rL285698: Minidump plugin: Fix flaky test.
Minidump plugin: Fix flaky test
Nov 1 2016, 8:58 AM
dvlahovski closed D26193: Minidump plugin: Fix flaky test by committing rL285698: Minidump plugin: Fix flaky test.
Nov 1 2016, 8:57 AM
dvlahovski retitled D26193: Minidump plugin: Fix flaky test from to Minidump plugin: Fix flaky test.
Nov 1 2016, 8:32 AM

Oct 31 2016

dvlahovski committed rL285587: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin….
Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin…
Oct 31 2016, 8:45 AM
dvlahovski closed D25905: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull by committing rL285587: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin….
Oct 31 2016, 8:44 AM
dvlahovski committed rL285584: Minidump plugin: Adding x86_32 register context converter.
Minidump plugin: Adding x86_32 register context converter
Oct 31 2016, 8:36 AM
dvlahovski closed D25832: Minidump plugin: Adding x86_32 register context converter by committing rL285584: Minidump plugin: Adding x86_32 register context converter.
Oct 31 2016, 8:36 AM

Oct 28 2016

dvlahovski updated the diff for D25905: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull.

Hopefully removing code that's not for this CL

Oct 28 2016, 3:44 AM

Oct 25 2016

dvlahovski added inline comments to D25905: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull.
Oct 25 2016, 8:19 AM
dvlahovski updated the diff for D25905: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull.

Formatting correctly the test files source code, and added explanation in their makefile
ReadModuleList() is called in DoLoadCore()

Oct 25 2016, 8:17 AM

Oct 24 2016

dvlahovski added a comment to D25905: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull.

Please ignore the RegisterContextMinidump_x86_* changes. Can't seem to make arc diff understand what I want.

Oct 24 2016, 11:38 AM
dvlahovski updated the diff for D25905: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull.

Addressed Pavel's comments.

Oct 24 2016, 11:34 AM
dvlahovski added inline comments to D25832: Minidump plugin: Adding x86_32 register context converter.
Oct 24 2016, 7:47 AM
dvlahovski updated the diff for D25832: Minidump plugin: Adding x86_32 register context converter.

Fixes regarding Pavel's comments

Oct 24 2016, 7:46 AM
dvlahovski retitled D25905: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull from to Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull.
Oct 24 2016, 5:57 AM

Oct 20 2016

dvlahovski retitled D25832: Minidump plugin: Adding x86_32 register context converter from to Minidump plugin: Adding x86_32 register context converter.
Oct 20 2016, 10:12 AM
dvlahovski committed rL284741: Minidump plugin: redesign the x86_64 register context.
Minidump plugin: redesign the x86_64 register context
Oct 20 2016, 9:11 AM
dvlahovski closed D25677: Minidump plugin: redesign the x86_64 register context by committing rL284741: Minidump plugin: redesign the x86_64 register context.
Oct 20 2016, 9:11 AM

Oct 19 2016

dvlahovski updated the diff for D25677: Minidump plugin: redesign the x86_64 register context.

Simplified writeRegister function

Oct 19 2016, 8:12 AM
dvlahovski committed rL284593: Minidump plugin: functions parsing memory structures and filtering module list.
Minidump plugin: functions parsing memory structures and filtering module list
Oct 19 2016, 7:23 AM
dvlahovski closed D25569: Minidump plugin: functions parsing memory structures and filtering module list by committing rL284593: Minidump plugin: functions parsing memory structures and filtering module list.
Oct 19 2016, 7:23 AM

Oct 18 2016

dvlahovski updated the diff for D25677: Minidump plugin: redesign the x86_64 register context.

Merge if's checking the same context flag

Oct 18 2016, 6:07 AM

Oct 17 2016

dvlahovski updated the diff for D25677: Minidump plugin: redesign the x86_64 register context.

Make a single array of sse registers instead of separated fields

Oct 17 2016, 9:04 AM
dvlahovski updated the diff for D25677: Minidump plugin: redesign the x86_64 register context.

Return a nullptr in case of an error

Oct 17 2016, 8:59 AM
dvlahovski updated the diff for D25677: Minidump plugin: redesign the x86_64 register context.

Adding sanity check for the context's size

Oct 17 2016, 8:22 AM
dvlahovski retitled D25677: Minidump plugin: redesign the x86_64 register context from to Minidump plugin: redesign the x86_64 register context.
Oct 17 2016, 7:40 AM
dvlahovski updated D25569: Minidump plugin: functions parsing memory structures and filtering module list.
Oct 17 2016, 4:11 AM
dvlahovski added inline comments to D25569: Minidump plugin: functions parsing memory structures and filtering module list.
Oct 17 2016, 4:09 AM
dvlahovski updated the diff for D25569: Minidump plugin: functions parsing memory structures and filtering module list.

Changed std::map with llvm::StringMap
Using containter.empty() instead of containter.size() == 0
Avoiding copy by using for(const auto& ...)
Added bitwise operations to the new enum classes

Oct 17 2016, 4:09 AM

Oct 14 2016

dvlahovski updated the diff for D25569: Minidump plugin: functions parsing memory structures and filtering module list.

Resolved Pavel's remarks.

Oct 14 2016, 8:31 AM

Oct 13 2016

dvlahovski retitled D25569: Minidump plugin: functions parsing memory structures and filtering module list from Minidump plugin: memory stuff and filtering module list to Minidump plugin: functions parsing memory structures and filtering module list.
Oct 13 2016, 11:08 AM
dvlahovski updated the diff for D25569: Minidump plugin: functions parsing memory structures and filtering module list.

Forgot to run clang-format. Also changed a helper function in the tests to make it simpler.

Oct 13 2016, 11:06 AM
dvlahovski retitled D25569: Minidump plugin: functions parsing memory structures and filtering module list from to Minidump plugin: memory stuff and filtering module list.
Oct 13 2016, 10:32 AM

Oct 5 2016

dvlahovski committed rL283352: Removing the new Minidump plugin.
Removing the new Minidump plugin
Oct 5 2016, 11:20 AM
dvlahovski committed rL283324: xfailing minidump tests again ... :(.
xfailing minidump tests again ... :(
Oct 5 2016, 8:09 AM
dvlahovski committed rL283321: Fixing new Minidump plugin tests.
Fixing new Minidump plugin tests
Oct 5 2016, 7:44 AM

Oct 4 2016

dvlahovski committed rL283263: xfailing tests for Minidump plugin.
xfailing tests for Minidump plugin
Oct 4 2016, 3:04 PM
dvlahovski committed rL283259: Adding a new Minidump post-mortem debugging plugin.
Adding a new Minidump post-mortem debugging plugin
Oct 4 2016, 2:11 PM
dvlahovski closed D25196: Adding a new Minidump post-mortem debugging plugin by committing rL283259: Adding a new Minidump post-mortem debugging plugin.
Oct 4 2016, 2:11 PM
dvlahovski updated the diff for D25196: Adding a new Minidump post-mortem debugging plugin.

Added a sanity check for loc_descr

Oct 4 2016, 1:00 PM
dvlahovski added inline comments to D25196: Adding a new Minidump post-mortem debugging plugin.
Oct 4 2016, 12:08 PM
dvlahovski updated the diff for D25196: Adding a new Minidump post-mortem debugging plugin.

Changes after Zachary's comments

Oct 4 2016, 12:06 PM
dvlahovski updated the diff for D25196: Adding a new Minidump post-mortem debugging plugin.

Second iteration over CL - regarded Pavel's comments and encapsulated m_data_sp more in MinidumpParser

Oct 4 2016, 11:35 AM
dvlahovski updated the diff for D25196: Adding a new Minidump post-mortem debugging plugin.

Updated the CL with regard to Pavel's comments

Oct 4 2016, 10:14 AM
dvlahovski added inline comments to D25196: Adding a new Minidump post-mortem debugging plugin.
Oct 4 2016, 2:31 AM

Oct 3 2016

dvlahovski added inline comments to D25196: Adding a new Minidump post-mortem debugging plugin.
Oct 3 2016, 2:10 PM
dvlahovski added a comment to D25196: Adding a new Minidump post-mortem debugging plugin.

I was hoping that, with your new mini dump parser, you'd be able to eliminate the need for the Windows-specific minidump process plugin.

When I wrote the Windows mini dump plugin, I tried to isolate the Windows API-specific bits using the pimpl idiom. Now that you've written a mini dump parser, we shouldn't need the Windows API calls, and nearly all the rest of the code should be shareable between Windows and Linux. Is there a plan to eliminate this redundancy and merge this new mini dump process plugin with the Windows-specific one?

Oct 3 2016, 11:39 AM
dvlahovski added inline comments to D25196: Adding a new Minidump post-mortem debugging plugin.
Oct 3 2016, 11:34 AM
dvlahovski added a comment to D25196: Adding a new Minidump post-mortem debugging plugin.

So, there will be changes to the way I handle the case where there is no ExceptionStream - I will probably create a StopReason = None. But I have to investigate if in that case lldb still hangs because it's trying to resume a process (that does not exists). I will ask Jim Ingham about some insight about StopReasons

Oct 3 2016, 10:32 AM
dvlahovski retitled D25196: Adding a new Minidump post-mortem debugging plugin from to Adding a new Minidump post-mortem debugging plugin.
Oct 3 2016, 9:44 AM

Sep 30 2016

dvlahovski committed rL282866: Again fixing windows build breakage like in rL282862.
Again fixing windows build breakage like in rL282862
Sep 30 2016, 8:50 AM
dvlahovski committed rL282862: Fixing windows build breakage caused by rL282822.
Fixing windows build breakage caused by rL282822
Sep 30 2016, 7:45 AM

Sep 27 2016

dvlahovski committed rL282529: Adding a RegisterContextMinidump_x86_64 converter.
Adding a RegisterContextMinidump_x86_64 converter
Sep 27 2016, 12:14 PM
dvlahovski closed D24919: Adding a RegisterContextMinidump_x86_64 converter by committing rL282529: Adding a RegisterContextMinidump_x86_64 converter.
Sep 27 2016, 12:14 PM
dvlahovski updated the diff for D24919: Adding a RegisterContextMinidump_x86_64 converter.

I like the combined approach more. So this is the implementation

Sep 27 2016, 12:11 PM
dvlahovski added inline comments to D24919: Adding a RegisterContextMinidump_x86_64 converter.
Sep 27 2016, 9:15 AM
dvlahovski added a comment to D24919: Adding a RegisterContextMinidump_x86_64 converter.

Thanks for the explanation and examples! :) Will keep this in mind in the future.

Sep 27 2016, 8:56 AM
dvlahovski updated the diff for D24919: Adding a RegisterContextMinidump_x86_64 converter.

Addressing Zachary's and Adrian's comments

Sep 27 2016, 8:33 AM
dvlahovski added inline comments to D24919: Adding a RegisterContextMinidump_x86_64 converter.
Sep 27 2016, 8:31 AM
dvlahovski added a comment to rL282452: [lit] Add a --max-failures option..

Just wanted to ping you because I changed a bit this revision in rL282479 because it was breaking the lldb build on windows7-android
http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/8612
http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/8612/steps/run%20unit%20tests/logs/stdio

Sep 27 2016, 5:10 AM
dvlahovski committed rL282479: Trying to fix lldb build breakage probably caused by rL282452.
Trying to fix lldb build breakage probably caused by rL282452
Sep 27 2016, 3:43 AM

Sep 26 2016

dvlahovski added inline comments to D24919: Adding a RegisterContextMinidump_x86_64 converter.
Sep 26 2016, 11:08 AM
dvlahovski added inline comments to D24919: Adding a RegisterContextMinidump_x86_64 converter.
Sep 26 2016, 10:10 AM
dvlahovski added inline comments to D24919: Adding a RegisterContextMinidump_x86_64 converter.
Sep 26 2016, 10:07 AM
dvlahovski added a comment to D24919: Adding a RegisterContextMinidump_x86_64 converter.

I will fix the comments that Zachary made in the next revision

Sep 26 2016, 10:05 AM
dvlahovski updated the diff for D24919: Adding a RegisterContextMinidump_x86_64 converter.

Updating the CL regarding Pavel's comments

Sep 26 2016, 10:01 AM
dvlahovski added a comment to D24919: Adding a RegisterContextMinidump_x86_64 converter.

I tested this on the yet-to-be-submitted plugin code and it works fine on Linux (should work fine everywhere for that matter). I can do a backtrace, go up/down the stack frames and, of course, see all of the registers with register read

Sep 26 2016, 8:55 AM
dvlahovski retitled D24919: Adding a RegisterContextMinidump_x86_64 converter from to Adding a RegisterContextMinidump_x86_64 converter.
Sep 26 2016, 8:53 AM

Sep 15 2016

dvlahovski committed rL281606: Reformat x86_64 register infos defines table.
Reformat x86_64 register infos defines table
Sep 15 2016, 6:07 AM

Sep 13 2016

dvlahovski committed rL281349: Fix a merge mishap in rL281348.
Fix a merge mishap in rL281348
Sep 13 2016, 9:30 AM
dvlahovski committed rL281348: MinidumpParsing: pid, modules, exceptions, strings.
MinidumpParsing: pid, modules, exceptions, strings
Sep 13 2016, 9:03 AM
dvlahovski closed D24385: MinidumpParsing: pid, modules, exceptions by committing rL281348: MinidumpParsing: pid, modules, exceptions, strings.
Sep 13 2016, 9:03 AM
dvlahovski updated the diff for D24385: MinidumpParsing: pid, modules, exceptions.

Making the LinuxProcStatus a smarter class

Sep 13 2016, 6:16 AM
dvlahovski updated the diff for D24385: MinidumpParsing: pid, modules, exceptions.

Removed consumeString; Fixed comparisons in unittests; out-of-bounds check in MinidumpString parsing

Sep 13 2016, 5:54 AM

Sep 12 2016

dvlahovski added inline comments to D24385: MinidumpParsing: pid, modules, exceptions.
Sep 12 2016, 10:08 AM
dvlahovski updated the diff for D24385: MinidumpParsing: pid, modules, exceptions.

Changes regarding all of the comments.

Sep 12 2016, 10:00 AM

Sep 9 2016

dvlahovski added a comment to D24385: MinidumpParsing: pid, modules, exceptions.

Also added parsing code for Minidump strings - the strings in the Minidump format are UTF-16 encoded. I used the code from the WinMiniDump plugin and it can extract a UTF-16 string and convert it to a UTF-8 one.

Sep 9 2016, 5:52 AM
dvlahovski updated the diff for D24385: MinidumpParsing: pid, modules, exceptions.

Forgot to run clang-format

Sep 9 2016, 5:47 AM
dvlahovski retitled D24385: MinidumpParsing: pid, modules, exceptions from to MinidumpParsing: pid, modules, exceptions.
Sep 9 2016, 5:43 AM
dvlahovski committed rL281030: Fixing a build breakage caused from a change in LLVM rL281019.
Fixing a build breakage caused from a change in LLVM rL281019
Sep 9 2016, 3:22 AM
dvlahovski closed D24382: Fixing a build breakage caused from a change in LLVM rL281019 by committing rL281030: Fixing a build breakage caused from a change in LLVM rL281019.
Sep 9 2016, 3:22 AM
dvlahovski retitled D24382: Fixing a build breakage caused from a change in LLVM rL281019 from to Fixing a build breakage caused from a change in LLVM rL281019.
Sep 9 2016, 3:21 AM

Sep 6 2016

dvlahovski committed rL280707: Fixing an MSVC error from rL280692.
Fixing an MSVC error from rL280692
Sep 6 2016, 5:56 AM
dvlahovski committed rL280703: Revert "Intel(R) Memory Protection Extensions (Intel(R) MPX) support.".
Revert "Intel(R) Memory Protection Extensions (Intel(R) MPX) support."
Sep 6 2016, 4:09 AM
dvlahovski added a reverting change for rL280668: Intel(R) Memory Protection Extensions (Intel(R) MPX) support.: rL280703: Revert "Intel(R) Memory Protection Extensions (Intel(R) MPX) support.".
Sep 6 2016, 4:09 AM

Sep 2 2016

dvlahovski added inline comments to D23545: Minidump parsing.
Sep 2 2016, 4:11 AM

Sep 1 2016

dvlahovski committed rL280356: Minidump parsing.
Minidump parsing
Sep 1 2016, 4:38 AM
dvlahovski closed D23545: Minidump parsing by committing rL280356: Minidump parsing.
Sep 1 2016, 4:38 AM

Aug 26 2016

dvlahovski updated the diff for D23545: Minidump parsing.

Making MinidumpParser constuctor private

Aug 26 2016, 4:02 AM

Aug 25 2016

dvlahovski added a comment to D23545: Minidump parsing.

I changed all of the llvm::Optional<const type *> returning functions to return only const type *
and signalize for 'failure' by returning a nullptr. In the cases where I return objects (e.g. vector of threads)
I'm still using the llvm::Optional pattern.
I also think that using llvm::Error is a good idea, but I think that it'll be difficult, because of
collisions with the lldb::Error, and also at some point I have to convert objects from one type to the other.

Aug 25 2016, 8:38 AM
dvlahovski updated the diff for D23545: Minidump parsing.

Changed the constructing pattern of MinidumpParser

Aug 25 2016, 8:33 AM

Aug 19 2016

dvlahovski updated the diff for D23545: Minidump parsing.

Move creation of ArrayRef after sanity check

Aug 19 2016, 8:11 AM