This is an archive of the discontinued LLVM Phabricator instance.

Differential D42315

[sanitizer] Allow Fuchsia to use getauxval
ClosedPublic

Authored by cryptoad on Jan 19 2018, 1:48 PM.

Details

Reviewers
alekseyshl
flowerhack
Commits
rG0fb904325a04: [sanitizer] Allow Fuchsia to use getauxval
rL323002: [sanitizer] Allow Fuchsia to use getauxval
rCRT323002: [sanitizer] Allow Fuchsia to use getauxval
Summary

Fuchsia has getauxval (https://fuchsia.googlesource.com/zircon/+/master/third_party/ulib/musl/include/sys/auxv.h,
https://fuchsia.googlesource.com/zircon/+/master/third_party/ulib/musl/src/misc/getauxval.c)
so set SANITIZER_USE_GETAUXVAL to 1 for this platform.

Diff Detail

Event Timeline

cryptoad created this revision.Jan 19 2018, 1:48 PM
Herald added subscribers: Restricted Project, kubamracek, srhines. · View Herald TranscriptJan 19 2018, 1:48 PM
Harbormaster completed remote builds in B14042: Diff 130683.Jan 19 2018, 1:50 PM
flowerhack accepted this revision.Jan 19 2018, 2:16 PM
This revision is now accepted and ready to land.Jan 19 2018, 2:16 PM
Closed by commit rCRT323002: [sanitizer] Allow Fuchsia to use getauxval (authored by cryptoad). · Explain WhyJan 19 2018, 2:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
sanitizer_common/
7 lines

Diff 130696

lib/sanitizer_common/sanitizer_getauxval.h

Show All 12 Lines
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef SANITIZER_GETAUXVAL_H #ifndef SANITIZER_GETAUXVAL_H
#define SANITIZER_GETAUXVAL_H #define SANITIZER_GETAUXVAL_H
#include "sanitizer_platform.h" #include "sanitizer_platform.h"
#if SANITIZER_LINUX #if SANITIZER_LINUX || SANITIZER_FUCHSIA
# include <features.h> # include <features.h>
# ifndef __GLIBC_PREREQ # ifndef __GLIBC_PREREQ
# define __GLIBC_PREREQ(x, y) 0 # define __GLIBC_PREREQ(x, y) 0
# endif # endif
# if __GLIBC_PREREQ(2, 16) || (SANITIZER_ANDROID && __ANDROID_API__ >= 21) # if __GLIBC_PREREQ(2, 16) || (SANITIZER_ANDROID && __ANDROID_API__ >= 21) || \
SANITIZER_FUCHSIA
# define SANITIZER_USE_GETAUXVAL 1 # define SANITIZER_USE_GETAUXVAL 1
# else # else
# define SANITIZER_USE_GETAUXVAL 0 # define SANITIZER_USE_GETAUXVAL 0
# endif # endif
# if SANITIZER_USE_GETAUXVAL # if SANITIZER_USE_GETAUXVAL
# include <sys/auxv.h> # include <sys/auxv.h>
# else # else
// The weak getauxval definition allows to check for the function at runtime. // The weak getauxval definition allows to check for the function at runtime.
// This is useful for Android, when compiled at a lower API level yet running // This is useful for Android, when compiled at a lower API level yet running
// on a more recent platform that offers the function. // on a more recent platform that offers the function.
extern "C" SANITIZER_WEAK_ATTRIBUTE extern "C" SANITIZER_WEAK_ATTRIBUTE
unsigned long getauxval(unsigned long type); // NOLINT unsigned long getauxval(unsigned long type); // NOLINT
# endif # endif
#endif // SANITIZER_LINUX #endif // SANITIZER_LINUX || SANITIZER_FUCHSIA
#endif // SANITIZER_GETAUXVAL_H #endif // SANITIZER_GETAUXVAL_H