This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Fix for the Scudo interface function scope
ClosedPublic

Authored by cryptoad on Jan 17 2018, 2:49 PM.

Details

Summary

A forgotten include in scudo_allocator.cpp made the symbol only local :/

Before:

nm ./lib/clang/7.0.0/lib/linux/libclang_rt.scudo-i686-android.so | grep rss
00024730 t __scudo_set_rss_limit

After:

nm ./lib/clang/7.0.0/lib/linux/libclang_rt.scudo-i686-android.so | grep rs
00024760 T __scudo_set_rss_limit

And we want T!

This include also means that we can get rid of the extern "C" in the C++
file, the compiler does fine without it (note that this was already the case
for all the __sanitizer_* interface functions.

Event Timeline

cryptoad created this revision.Jan 17 2018, 2:49 PM
Herald added a subscriber: Restricted Project. · View Herald TranscriptJan 17 2018, 2:49 PM
eugenis accepted this revision.Jan 17 2018, 3:06 PM
This revision is now accepted and ready to land.Jan 17 2018, 3:06 PM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.