This is an archive of the discontinued LLVM Phabricator instance.

Differential D42156

Force lit to execute the ASan and TSan tests on iOS devices sequentially
ClosedPublic

Authored by delcypher on Jan 16 2018, 6:02 PM.

Details

Reviewers
kubamracek
kcc
filcab
fjricci
Commits
rG3fc243aea52c: Force lit to execute the ASan and TSan tests on iOS devices sequentially.
rCRT323026: Force lit to execute the ASan and TSan tests on iOS devices
rL323026: Force lit to execute the ASan and TSan tests on iOS devices
Summary

The current implementation of commands in
test/sanitizer_common/ios_commands/ for iOS devices cannot be executed
in parallel which results in the ASan and TSan tests failing when
executed in parallel by lit which was the default behaviour.

We now force the ASan and TSan tests to be a new parallelism group named
darwin-ios-device-sanitizer which allows only one test to be run at a
time. We also emit a warning informing the user that tests are being
run sequentially.

This only applies if the target is an iOS device.

Diff Detail

Repository
rL LLVM

Event Timeline

delcypher created this revision.Jan 16 2018, 6:02 PM
Herald added a subscriber: Restricted Project. · View Herald TranscriptJan 16 2018, 6:02 PM
delcypher added reviewers: kcc, filcab, fjricci.Jan 16 2018, 6:05 PM
kubamracek added inline comments.Jan 16 2018, 8:56 PM
test/asan/lit.cfg
223 ↗(On Diff #130080)

Do we need the warning? I would prefer to drop it. If you think it's still useful, please use the spelling "iOS" for the name of the OS.

224 ↗(On Diff #130080)

Can the value "1" and the comment be moved to test/lit.common.cfg?

delcypher added inline comments.Jan 17 2018, 7:55 PM
test/asan/lit.cfg
223 ↗(On Diff #130080)

It's not essential but I think it's misleading if we don't warn about this. When lit runs it claims its using N threads (where N is the number of logic cores you have) but lit won't actually be doing this. Lit will effectively be running with one thread.

224 ↗(On Diff #130080)

I'll take a look. I'm think this might hurt clarity a bit but I'll do it anyway.

delcypher updated this revision to Diff 130355.Jan 17 2018, 8:17 PM

Address first round of feedback.

delcypher marked 2 inline comments as done.Jan 17 2018, 8:18 PM
delcypher marked an inline comment as done.
kubamracek added inline comments.Jan 17 2018, 8:21 PM
test/asan/lit.cfg
218 ↗(On Diff #130355)

Should this be config.ios and not config.iossim? Note that config.ios is "true" even for the simulator.

test/lit.common.cfg
297 ↗(On Diff #130355)

drop the "and config.ios" part of the condition

delcypher added inline comments.Jan 17 2018, 8:25 PM
test/lit.common.cfg
297 ↗(On Diff #130355)

If we do that the warning will be wrong. It will fire if the host is Darwin, regardless of if the target is an iOS device or not.

kubamracek added inline comments.Jan 17 2018, 8:26 PM
test/lit.common.cfg
297 ↗(On Diff #130355)

Ok, keep it then.

delcypher added inline comments.Jan 17 2018, 8:27 PM
test/asan/lit.cfg
218 ↗(On Diff #130355)

Good catch. I hadn't noticed that.

delcypher updated this revision to Diff 130357.Jan 17 2018, 8:37 PM

Address forgetting to check value of config.iossim.

kubamracek accepted this revision.Jan 17 2018, 8:39 PM

LGTM.

This revision is now accepted and ready to land.Jan 17 2018, 8:39 PM
Closed by commit rL323026: Force lit to execute the ASan and TSan tests on iOS devices (authored by delcypher). · Explain WhyJan 19 2018, 6:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
test/
asan/
7 lines
8 lines
tsan/
7 lines

Diff 130738

compiler-rt/trunk/test/asan/lit.cfg

Show First 20 Lines • Show All 206 Lines • ▼ Show 20 Lineselse:
config.substitutions.append(('%fPIC', '-fPIC')) config.substitutions.append(('%fPIC', '-fPIC'))
config.substitutions.append(('%fPIE', '-fPIE')) config.substitutions.append(('%fPIE', '-fPIE'))
config.substitutions.append(('%pie', '-pie')) config.substitutions.append(('%pie', '-pie'))
# Only run the tests on supported OSs. # Only run the tests on supported OSs.
if config.host_os not in ['Linux', 'Darwin', 'FreeBSD', 'SunOS', 'Windows']: if config.host_os not in ['Linux', 'Darwin', 'FreeBSD', 'SunOS', 'Windows']:
config.unsupported = True config.unsupported = True
if config.host_os == 'Darwin' and config.target_arch in ["x86_64", "x86_64h"]: if config.host_os == 'Darwin':
if config.target_arch in ["x86_64", "x86_64h"]:
config.parallelism_group = "darwin-64bit-sanitizer" config.parallelism_group = "darwin-64bit-sanitizer"
elif config.ios and not config.iossim:
config.parallelism_group = "darwin-ios-device-sanitizer"

compiler-rt/trunk/test/lit.common.cfg

Show First 20 Lines • Show All 285 Lines • ▼ Show 20 Linesif platform.system() == 'Windows':
config.test_retry_attempts = 2 config.test_retry_attempts = 2
# Only run up to 3 64-bit sanitized processes simultaneously on Darwin. # Only run up to 3 64-bit sanitized processes simultaneously on Darwin.
# Using more scales badly and hogs the system due to inefficient handling # Using more scales badly and hogs the system due to inefficient handling
# of large mmap'd regions (terabytes) by the kernel. # of large mmap'd regions (terabytes) by the kernel.
if platform.system() == 'Darwin': if platform.system() == 'Darwin':
lit_config.parallelism_groups["darwin-64bit-sanitizer"] = 3 lit_config.parallelism_groups["darwin-64bit-sanitizer"] = 3
# The current implementation of the tools in sanitizer_common/ios_comamnds
# do not support parallel execution so force sequential execution of the
# tests on iOS devices.
if config.host_os == 'Darwin' and config.ios and not config.iossim:
lit_config.warning("iOS device test cases being run sequentially")
lit_config.parallelism_groups["darwin-ios-device-sanitizer"] = 1
if config.host_os == 'Darwin': if config.host_os == 'Darwin':
config.substitutions.append( ("%ld_flags_rpath_exe", '-Wl,-rpath,@executable_path/ %dynamiclib') ) config.substitutions.append( ("%ld_flags_rpath_exe", '-Wl,-rpath,@executable_path/ %dynamiclib') )
config.substitutions.append( ("%ld_flags_rpath_so", '-install_name @rpath/`basename %dynamiclib`') ) config.substitutions.append( ("%ld_flags_rpath_so", '-install_name @rpath/`basename %dynamiclib`') )
elif config.host_os == 'FreeBSD': elif config.host_os == 'FreeBSD':
config.substitutions.append( ("%ld_flags_rpath_exe", "-Wl,-z,origin -Wl,-rpath,\$ORIGIN -L%T -l%xdynamiclib_namespec") ) config.substitutions.append( ("%ld_flags_rpath_exe", "-Wl,-z,origin -Wl,-rpath,\$ORIGIN -L%T -l%xdynamiclib_namespec") )
config.substitutions.append( ("%ld_flags_rpath_so", '') ) config.substitutions.append( ("%ld_flags_rpath_so", '') )
elif config.host_os == 'Linux': elif config.host_os == 'Linux':
config.substitutions.append( ("%ld_flags_rpath_exe", "-Wl,-rpath,\$ORIGIN -L%T -l%xdynamiclib_namespec") ) config.substitutions.append( ("%ld_flags_rpath_exe", "-Wl,-rpath,\$ORIGIN -L%T -l%xdynamiclib_namespec") )
▲ Show 20 Lines • Show All 47 Lines • Show Last 20 Lines

compiler-rt/trunk/test/tsan/lit.cfg

Show First 20 Lines • Show All 79 Lines • ▼ Show 20 Lines
config.suffixes = ['.c', '.cc', '.cpp', '.m', '.mm'] config.suffixes = ['.c', '.cc', '.cpp', '.m', '.mm']
if config.host_os not in ['FreeBSD', 'Linux', 'Darwin', 'NetBSD']: if config.host_os not in ['FreeBSD', 'Linux', 'Darwin', 'NetBSD']:
config.unsupported = True config.unsupported = True
if config.android: if config.android:
config.unsupported = True config.unsupported = True
if config.host_os == 'Darwin' and config.target_arch in ["x86_64", "x86_64h"]: if config.host_os == 'Darwin':
if config.target_arch in ["x86_64", "x86_64h"]:
config.parallelism_group = "darwin-64bit-sanitizer" config.parallelism_group = "darwin-64bit-sanitizer"
elif config.ios and not config.iossim:
config.parallelism_group = "darwin-ios-device-sanitizer"