This is an archive of the discontinued LLVM Phabricator instance.

[llvm-cov] Improvements for summary report generated in HTML format.
ClosedPublic

Authored by Dor1s on Jan 15 2018, 10:20 PM.

Details

Summary

This commit adds the following changes:

  1. coverage numbers are aligned to the left and padded with spaces in order to

provide better readability for percentage values, e.g.:

file1     |  89.13% (123 / 2323)    | 100.00% (55 / 55)    |   9.33% (14545 / 234234)
file_asda |   1.78% ( 23 / 4323)    |  32.31% (555 / 6555) |  67.89% (1545 / 2234)
fileXXX   | 100.00% (12323 / 12323) | 100.00% (555 / 555)  | 100.00% (12345 / 12345)
  1. added "hover" attribute to CSS for highlighting table row under mouse cursor

see screenshot attached to the phabricator review page

  1. table title row and "totals" row now use bold text

Diff Detail

Repository
rL LLVM

Event Timeline

Dor1s created this revision.Jan 15 2018, 10:20 PM

I need to fix some style-related tests, but first I'd like to see what you think about the change.

Please take a look :)

Dor1s edited the summary of this revision. (Show Details)Jan 15 2018, 10:27 PM

Changes look nice visually. I think standard practice is to right-align numerical entries, but that might require a bit more work to pad properly.

Changes look nice visually. I think standard practice is to right-align numerical entries, but that might require a bit more work to pad properly.

Yeah... I can add more padding from the left, if it feels better.

Dor1s added a comment.Jan 24 2018, 3:13 PM

Vedant, friendly ping :)

vsk accepted this revision.Jan 24 2018, 3:16 PM

Looks good from my end, sorry for the delay.

This revision is now accepted and ready to land.Jan 24 2018, 3:16 PM
Dor1s updated this revision to Diff 132109.Jan 31 2018, 12:55 AM

Update the tests

Dor1s updated this revision to Diff 132110.Jan 31 2018, 12:57 AM

Minor test improvement

This revision was automatically updated to reflect the committed changes.