This is an archive of the discontinued LLVM Phabricator instance.

Differential D42066

Add new interceptor: acct(2)
ClosedPublic

Authored by krytarowski on Jan 15 2018, 5:10 AM.

Details

Reviewers
joerg
vitalybuka
Commits
rGb87c8fa45634: Add new interceptor: acct(2)
rL322646: Add new interceptor: acct(2)
rCRT322646: Add new interceptor: acct(2)
Summary

acct - enable or disable process accounting

Sponsored by <The NetBSD Foundation>

Diff Detail

Event Timeline

krytarowski created this revision.Jan 15 2018, 5:10 AM
Herald added a subscriber: kubamracek. · View Herald TranscriptJan 15 2018, 5:10 AM
vitalybuka accepted this revision.Jan 16 2018, 5:01 PM
vitalybuka added inline comments.
lib/sanitizer_common/sanitizer_common_interceptors.inc
6467

"const char *"?

6470

please remove {}

This revision is now accepted and ready to land.Jan 16 2018, 5:01 PM
krytarowski added inline comments.Jan 16 2018, 5:05 PM
lib/sanitizer_common/sanitizer_common_interceptors.inc
6467

I try to omit const in order to prevent "const pollution" phenomena. It might be fine for so short interceptors thought.

This is my motivation and decision is up to you.

vitalybuka added a comment.Jan 16 2018, 5:11 PM

Oh, maybe test?

lib/sanitizer_common/sanitizer_common_interceptors.inc
6467

function is declared with const

vitalybuka added a comment.Jan 16 2018, 5:14 PM

Could you please don't copy man into the summary?

krytarowski edited the summary of this revision. (Show Details)Jan 16 2018, 6:15 PM
krytarowski updated this revision to Diff 130143.Jan 17 2018, 5:05 AM

Remove {}
constify input argument

Closed by commit rCRT322646: Add new interceptor: acct(2) (authored by kamil). · Explain WhyJan 17 2018, 5:06 AM
This revision was automatically updated to reflect the committed changes.
vitalybuka added a comment.Jan 17 2018, 3:44 PM

test?

krytarowski added a comment.Jan 19 2018, 7:11 AM
In D42066#979528, @vitalybuka wrote:

test?

Better not, this changes global system accounting properties and this call is reserved for a super-user only.

This call is tested with the userland utilities.

Revision Contents

PathSize
lib/
sanitizer_common/
14 lines
2 lines

Diff 130144

lib/sanitizer_common/sanitizer_common_interceptors.inc

Show First 20 Lines • Show All 6,457 Lines • ▼ Show 20 Lines
} }
#define INIT_WCSCAT \ #define INIT_WCSCAT \
COMMON_INTERCEPT_FUNCTION(wcscat); \ COMMON_INTERCEPT_FUNCTION(wcscat); \
COMMON_INTERCEPT_FUNCTION(wcsncat); COMMON_INTERCEPT_FUNCTION(wcsncat);
#else #else
#define INIT_WCSCAT #define INIT_WCSCAT
#endif #endif
#if SANITIZER_INTERCEPT_ACCT
INTERCEPTOR(int, acct, const char *file) {
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

"const char *"?

vitalybuka: "const char *"?
krytarowskiAuthorUnsubmitted
Not Done
ReplyInline Actions

I try to omit const in order to prevent "const pollution" phenomena. It might be fine for so short interceptors thought.

This is my motivation and decision is up to you.

krytarowski: I try to omit const in order to prevent "const pollution" phenomena. It might be fine for so…
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

function is declared with const

vitalybuka: function is declared with const
void *ctx;
COMMON_INTERCEPTOR_ENTER(ctx, acct, file);
if (file)
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

please remove {}

vitalybuka: please remove {}
COMMON_INTERCEPTOR_READ_RANGE(ctx, file, REAL(strlen)(file) + 1);
return REAL(acct)(file);
}
#define INIT_ACCT COMMON_INTERCEPT_FUNCTION(acct)
#else
#define INIT_ACCT
#endif
static void InitializeCommonInterceptors() { static void InitializeCommonInterceptors() {
static u64 metadata_mem[sizeof(MetadataHashMap) / sizeof(u64) + 1]; static u64 metadata_mem[sizeof(MetadataHashMap) / sizeof(u64) + 1];
interceptor_metadata_map = new((void *)&metadata_mem) MetadataHashMap(); interceptor_metadata_map = new((void *)&metadata_mem) MetadataHashMap();
INIT_TEXTDOMAIN; INIT_TEXTDOMAIN;
INIT_STRLEN; INIT_STRLEN;
INIT_STRNLEN; INIT_STRNLEN;
INIT_STRNDUP; INIT_STRNDUP;
▲ Show 20 Lines • Show All 195 Lines • ▼ Show 20 Linesstatic void InitializeCommonInterceptors() {
INIT___LXSTAT; INIT___LXSTAT;
INIT___LXSTAT64; INIT___LXSTAT64;
// FIXME: add other *stat interceptors. // FIXME: add other *stat interceptors.
INIT_UTMP; INIT_UTMP;
INIT_UTMPX; INIT_UTMPX;
INIT_GETLOADAVG; INIT_GETLOADAVG;
INIT_WCSLEN; INIT_WCSLEN;
INIT_WCSCAT; INIT_WCSCAT;
INIT_ACCT;
#if SANITIZER_NETBSD #if SANITIZER_NETBSD
COMMON_INTERCEPT_FUNCTION(__libc_mutex_lock); COMMON_INTERCEPT_FUNCTION(__libc_mutex_lock);
COMMON_INTERCEPT_FUNCTION(__libc_mutex_unlock); COMMON_INTERCEPT_FUNCTION(__libc_mutex_unlock);
COMMON_INTERCEPT_FUNCTION(__libc_thr_setcancelstate); COMMON_INTERCEPT_FUNCTION(__libc_thr_setcancelstate);
#endif #endif
INIT___PRINTF_CHK; INIT___PRINTF_CHK;
} }

lib/sanitizer_common/sanitizer_platform_interceptors.h

Show First 20 Lines • Show All 426 Lines • ▼ Show 20 Lines#define SANITIZER_INTERCEPT_CFREE \
(!SI_FREEBSD && !SI_MAC && !SI_NETBSD && SI_NOT_FUCHSIA) (!SI_FREEBSD && !SI_MAC && !SI_NETBSD && SI_NOT_FUCHSIA)
#define SANITIZER_INTERCEPT_ALIGNED_ALLOC (!SI_MAC) #define SANITIZER_INTERCEPT_ALIGNED_ALLOC (!SI_MAC)
#define SANITIZER_INTERCEPT_MALLOC_USABLE_SIZE (!SI_MAC) #define SANITIZER_INTERCEPT_MALLOC_USABLE_SIZE (!SI_MAC)
#define SANITIZER_INTERCEPT_MCHECK_MPROBE SI_LINUX_NOT_ANDROID #define SANITIZER_INTERCEPT_MCHECK_MPROBE SI_LINUX_NOT_ANDROID
#define SANITIZER_INTERCEPT_WCSCAT SI_POSIX #define SANITIZER_INTERCEPT_WCSCAT SI_POSIX
#define SANITIZER_INTERCEPT_SIGNAL_AND_SIGACTION (!SI_WINDOWS && SI_NOT_FUCHSIA) #define SANITIZER_INTERCEPT_SIGNAL_AND_SIGACTION (!SI_WINDOWS && SI_NOT_FUCHSIA)
#define SANITIZER_INTERCEPT_BSD_SIGNAL SI_ANDROID #define SANITIZER_INTERCEPT_BSD_SIGNAL SI_ANDROID
#define SANITIZER_INTERCEPT_ACCT SI_NETBSD
#endif // #ifndef SANITIZER_PLATFORM_INTERCEPTORS_H #endif // #ifndef SANITIZER_PLATFORM_INTERCEPTORS_H