This is an archive of the discontinued LLVM Phabricator instance.

Add new NetBSD interceptors: getgrouplist(3) & getgroupmembership(3)
ClosedPublic

Authored by krytarowski on Jan 15 2018, 4:46 AM.

Diff Detail

Event Timeline

krytarowski created this revision.Jan 15 2018, 4:46 AM
krytarowski edited the summary of this revision. (Show Details)Jan 15 2018, 4:46 AM

Could you please remove copied man page from the summary? Not sure about licences there.

krytarowski edited the summary of this revision. (Show Details)Jan 16 2018, 5:15 PM
krytarowski edited the summary of this revision. (Show Details)

Tests?

lib/sanitizer_common/sanitizer_common_interceptors.inc
6476

you need COMMON_INTERCEPTOR_WRITE_RANGE(ctx, ngroups... as well

6478

add empty line between interceptors

6488

same about ngroups

resolve comments from review

krytarowski marked 3 inline comments as done.Jan 17 2018, 8:01 AM

Tests from this revision require merged another patch in D42068

test as is should be moved into sanitizer_common
However if we keep it here we can extend the test to check that it actually detects bugs. I am Ok with moving it into sanitizer_common

vitalybuka accepted this revision.Jan 17 2018, 3:23 PM
This revision is now accepted and ready to land.Jan 17 2018, 3:23 PM

Move tests to sanitizer_common

This revision was automatically updated to reflect the committed changes.