Page MenuHomePhabricator

[Driver] Suggest valid integrated tools
ClosedPublic

Authored by modocache on Jan 12 2018, 11:09 AM.

Details

Summary

There are only two valid integrated Clang driver tools: -cc1 and
-cc1as. If a user asks for an unknown tool, such as -cc1asphalt,
an error message is displayed to indicate that there is no such tool,
but the message doesn't indicate what the valid options are.

Include the valid options in the error message.

Test Plan: check-clang

Diff Detail

Repository
rC Clang

Event Timeline

modocache created this revision.Jan 12 2018, 11:09 AM
bkramer accepted this revision.Jan 15 2018, 4:46 AM

The -cc1 stuff isn't exactly user-facing, so we didn't put so much emphasis on providing great error messages there. This change LGTM.

This revision is now accepted and ready to land.Jan 15 2018, 4:46 AM
This revision was automatically updated to reflect the committed changes.

Great, thanks for the review @bkramer!