This is an archive of the discontinued LLVM Phabricator instance.

[DWARF][NFC] Prep for upcoming DWARF v5 string offsets table producer patch.
ClosedPublic

Authored by wolfgangp on Jan 10 2018, 2:57 PM.

Details

Summary

This is in preparation for an upcoming patch to implement the producer side of DWARF v5 string offsets tables. We'd like to use AsmPrinter's emitDwarfStringOffsets() with a simple DwarfStringPoolEntry record in order to emit string offsets from the DwarfStringPool class directly. Currently the method only takes a DwarfStringPoolEntryRef, which is awkward to construct from a DwarfStringPoolEntry and would create unnecessary overhead.

Diff Detail

Event Timeline

wolfgangp created this revision.Jan 10 2018, 2:57 PM
aprantl accepted this revision.Jan 10 2018, 3:28 PM

Could you please upload patches with more context in the future? git diff -U9999 is good :-)

This revision is now accepted and ready to land.Jan 10 2018, 3:28 PM
aprantl added inline comments.Jan 10 2018, 3:28 PM
include/llvm/CodeGen/DwarfStringPoolEntry.h
44

Comment perhaps?

wolfgangp marked an inline comment as done.Jan 10 2018, 5:42 PM

Could you please upload patches with more context in the future? git diff -U9999 is good :-)

Yeah, sorry, I usually do that. Somehow I forgot to do it this time.
Thanks for the quick review.

include/llvm/CodeGen/DwarfStringPoolEntry.h
44

Mostly a convenience, so the caller doesn't have to puzzle the string pool entry together from its components. I add a comment before I commit.

This revision was automatically updated to reflect the committed changes.
wolfgangp marked an inline comment as done.