This is an archive of the discontinued LLVM Phabricator instance.

[docs] Update Phabricator docs about setting repository for diffs uploaded via web
ClosedPublic

Authored by benhamilton on Jan 10 2018, 2:08 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

benhamilton created this revision.Jan 10 2018, 2:08 PM
asb added a comment.Jan 11 2018, 3:37 AM

Am I correct in thinking that as long as the repository field is filled out, there should never be a reason to explicitly add llvm-commits or cfe-commits to the subscriber list? If so it would probably make sense to remove the note "subscribe mailing lists that you want to be included in the review. If your patch is for LLVM, add llvm-commits as a Subscriber; if your patch is for Clang, add cfe-commits." Instead, you could expand the bullet point on the repository field to say "Entering the correct repository will ensure that the appropriate mailing list (llvm-commits or cfe-commits) is automatically subscribed to patch patch updates.

  • Update info on subscribing llvm-commits/cfe-commits

there should never be a reason to explicitly add llvm-commits or cfe-commits to the subscriber list?

Good catch, fixed.

asb accepted this revision.Jan 11 2018, 7:59 AM

Looks good to me!

This revision is now accepted and ready to land.Jan 11 2018, 7:59 AM
This revision was automatically updated to reflect the committed changes.