This is an archive of the discontinued LLVM Phabricator instance.

[Mips] Handle one byte unsupported relocations
ClosedPublic

Authored by smaksimovic on Jan 9 2018, 2:47 AM.

Diff Detail

Event Timeline

smaksimovic created this revision.Jan 9 2018, 2:47 AM
sdardis accepted this revision.Jan 10 2018, 2:31 PM

Two additional nits to the ones inlined, rather that use the term 'illegal' say 'unsupported', this goes for the title as well as the test file name.

Also, the summary should be "Fail gracefully" rather than "Exit gracefully".

Otherwise LGTM.

lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp
229

Nit: Mips does not support one byte fixups -> MIPS does not support one byte relocations

test/MC/Mips/illegal-relocation.s
3

Nit: description.

This revision is now accepted and ready to land.Jan 10 2018, 2:31 PM
smaksimovic retitled this revision from [Mips] Handle one byte illegal relocations to [Mips] Handle one byte unsupported relocations.
smaksimovic edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.