This is an archive of the discontinued LLVM Phabricator instance.

Differential D41807

[cmake] Delete redundant install command for clang-refactor.
ClosedPublic

Authored by hintonda on Jan 6 2018, 6:53 PM.

Details

Reviewers
arphaman
beanz
Commits
rG050b4b05a00a: [cmake] Delete redundant install command for clang-refactor.
rL322147: [cmake] Delete redundant install command for clang-refactor.
rC322147: [cmake] Delete redundant install command for clang-refactor.
Summary

Delete redundant install command for clang-refactor. Install
targets for clang tools are controled by CLANG_BUILD_TOOLS, and when
OFF, cmake issues the following warning:

WARNING: Target "clang-refactor" has EXCLUDE_FROM_ALL set and will not be built by default but an install rule has been provided for it. CMake does not define behavior for this case.

Diff Detail

Event Timeline

hintonda created this revision.Jan 6 2018, 6:53 PM
Herald added a subscriber: mgorny. · View Herald TranscriptJan 6 2018, 6:53 PM
beanz accepted this revision.Jan 9 2018, 3:19 PM

LGTM

This revision is now accepted and ready to land.Jan 9 2018, 3:19 PM
Closed by commit rC322147: [cmake] Delete redundant install command for clang-refactor. (authored by dhinton). · Explain WhyJan 9 2018, 5:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
clang-refactor/
2 lines

Diff 128864

tools/clang-refactor/CMakeLists.txt

Show All 14 Linestarget_link_libraries(clang-refactor
clangFormat clangFormat
clangFrontend clangFrontend
clangLex clangLex
clangRewrite clangRewrite
clangTooling clangTooling
clangToolingCore clangToolingCore
clangToolingRefactor clangToolingRefactor
) )
install(TARGETS clang-refactor RUNTIME DESTINATION bin)