Page MenuHomePhabricator

[Utils] Simplify salvageDebugInfo, NFCI
ClosedPublic

Authored by vsk on Jan 5 2018, 2:51 PM.

Details

Summary

Having a single call to findDbgUsers() allows salvageDebugInfo() to
return earlier.

Diff Detail

Repository
rL LLVM

Event Timeline

vsk created this revision.Jan 5 2018, 2:51 PM
aprantl accepted this revision.Jan 5 2018, 3:08 PM

Thumbs up for patches with a negative net line count!
Are there any remaining users of findDebugValues that don't actually want to use find DebugUsers?

This revision is now accepted and ready to land.Jan 5 2018, 3:08 PM
vsk added a comment.Jan 5 2018, 3:16 PM

Are there any remaining users of findDebugValues that don't actually want to use find DebugUsers?

There are two uses we should switch over to findDbgUsers. I have the change prepared, but still need to write tests.

davide accepted this revision.Jan 5 2018, 3:26 PM

LGTM, thanks Vedant!

This revision was automatically updated to reflect the committed changes.