This is an archive of the discontinued LLVM Phabricator instance.

[mips] Remove duplicated R6 EVA instructions
ClosedPublic

Authored by abeserminji on Jan 5 2018, 8:51 AM.

Diff Detail

Event Timeline

abeserminji created this revision.Jan 5 2018, 8:51 AM
sdardis accepted this revision.Jan 8 2018, 3:42 AM

Nit:

/Users/simon/dev/llvm/llvm/lib/Target/Mips/Disassembler/MipsDisassembler.cpp:1541:21: warning: unused function 'DecodeLoadByte9' [-Wunused-function]
static DecodeStatus DecodeLoadByte9(MCInst &Inst,
                    ^
/Users/simon/dev/llvm/llvm/lib/Target/Mips/Disassembler/MipsDisassembler.cpp:1645:21: warning: unused function 'DecodeStoreEvaOpMM' [-Wunused-function]
static DecodeStatus DecodeStoreEvaOpMM(MCInst &Inst,

These functions should be removed. Otherwise LGTM.

This revision is now accepted and ready to land.Jan 8 2018, 3:42 AM

Comments addressed.

This revision was automatically updated to reflect the committed changes.