This allows keeping libcxx using win32 threads even if a version of pthread.h is installed. This matches the existing cmake option LIBCXX_HAS_PTHREAD_API.
Details
Details
- Reviewers
compnerd EricWF smeenai - Commits
- rGbf02a0910334: [cmake] Add a config option LIBCXX_HAS_WIN32_THREAD_API for enforcing win32…
rCXX321896: [cmake] Add a config option LIBCXX_HAS_WIN32_THREAD_API for enforcing win32…
rL321896: [cmake] Add a config option LIBCXX_HAS_WIN32_THREAD_API for enforcing win32…
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
I think LIBCXX_HAS_WIN32_THREAD_API would be more consistent with the existing configuration define names?
CMakeLists.txt | ||
---|---|---|
277 ↗ | (On Diff #128734) | The inconsistent usage of if( vs if ( in this file is annoying me haha. Not this diff's fault of course, but still. |
Comment Actions
That sounds good to me too. I can update the patch later, or before committing if it's otherwise ok.
CMakeLists.txt | ||
---|---|---|
277 ↗ | (On Diff #128734) | Oh, yes... The new lines here were copypasted from the pthread ones a bit further above, explaining the inconsistency. |
Comment Actions
Can you add documentation for _LIBCPP_HAS_THREAD_API_WIN32 to docs/DesignDocs/ThreadingSupportAPI.rst? It should have been documented before, but this seems like a good opportunity to correct that.
LGTM with that and the rename.