This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Only attempt to install MSVC system libraries on Windows
ClosedPublic

Authored by smeenai on Dec 13 2017, 7:07 PM.

Details

Summary

Newer versions of CMake (I'm on 3.10, but I believe 3.9 behaves the same
way) attempt to query the system for information about the VS 2017
install. Unfortunately, this query fails on non-Windows systems:

cmake_host_system_information does not recognize <key> VS_15_DIR

CMake isn't going to find these system libraries on non-Windows anyway
(and we were previously silencing the resultant warnings in our
cross-compilation toolchain), so it makes sense to just omit the
attempted installation entirely on non-Windows.

Diff Detail

Repository
rL LLVM

Event Timeline

smeenai created this revision.Dec 13 2017, 7:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 14 2017, 10:42 AM
This revision was automatically updated to reflect the committed changes.