[asan] LIT: Add lld testing config.

[lebedev.ri]

Summary

A follow-up for D40768/D39508, with address sanitizer changes.

There is a problem:

$ ninja check-asan check-asan-dynamic
[34/37] Running the AddressSanitizer tests with dynamic runtime
FAIL: AddressSanitizer-lld-x86_64-linux-dynamic :: TestCases/Linux/asan_prelink_test.cc (242 of 1042)
******************** TEST 'AddressSanitizer-lld-x86_64-linux-dynamic :: TestCases/Linux/asan_prelink_test.cc' FAILED ********************
Script:
--
/build/llvm-build-Clang-release/./bin/clang  --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only  -m64 -fuse-ld=lld  -shared-libasan -c /build/compiler-rt/test/asan/TestCases/Linux/asan_prelink_test.cc -o /build/llvm-build-Clang-release/projects/compiler-rt/test/asan/LLDX86_64LinuxConfig/TestCases/Linux/Output/asan_prelink_test.cc.tmp.o
/build/llvm-build-Clang-release/./bin/clang  --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only  -m64 -fuse-ld=lld  -shared-libasan -DBUILD_SO=1 -fPIC -shared /build/compiler-rt/test/asan/TestCases/Linux/asan_prelink_test.cc -o /build/llvm-build-Clang-release/projects/compiler-rt/test/asan/LLDX86_64LinuxConfig/TestCases/Linux/Output/asan_prelink_test.cc.tmp.so -Wl,-Ttext-segment=0x3600000000 ||    /build/llvm-build-Clang-release/./bin/clang  --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only  -m64 -fuse-ld=lld  -shared-libasan -DBUILD_SO=1 -fPIC -shared /build/compiler-rt/test/asan/TestCases/Linux/asan_prelink_test.cc -o /build/llvm-build-Clang-release/projects/compiler-rt/test/asan/LLDX86_64LinuxConfig/TestCases/Linux/Output/asan_prelink_test.cc.tmp.so -Wl,-Ttext=0x3600000000
/build/llvm-build-Clang-release/./bin/clang  --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only  -m64 -fuse-ld=lld  -shared-libasan /build/llvm-build-Clang-release/projects/compiler-rt/test/asan/LLDX86_64LinuxConfig/TestCases/Linux/Output/asan_prelink_test.cc.tmp.o /build/llvm-build-Clang-release/projects/compiler-rt/test/asan/LLDX86_64LinuxConfig/TestCases/Linux/Output/asan_prelink_test.cc.tmp.so -Wl,-R. -o /build/llvm-build-Clang-release/projects/compiler-rt/test/asan/LLDX86_64LinuxConfig/TestCases/Linux/Output/asan_prelink_test.cc.tmp
env ASAN_OPTIONS=verbosity=1  /build/llvm-build-Clang-release/projects/compiler-rt/test/asan/LLDX86_64LinuxConfig/TestCases/Linux/Output/asan_prelink_test.cc.tmp 2>&1 | FileCheck /build/compiler-rt/test/asan/TestCases/Linux/asan_prelink_test.cc
--
Exit Code: 1

Command Output (stderr):
--
clang-6.0: warning: argument unused during compilation: '-fuse-ld=lld' [-Wunused-command-line-argument]
/build/compiler-rt/test/asan/TestCases/Linux/asan_prelink_test.cc:29:11: error: expected string not found in input
// CHECK: SO mapped at 3600000000
          ^
<stdin>:6:49: note: scanning from here
|| `[0x003000000000, 0x004fffffffff]` || MidMem ||
                                                ^
<stdin>:28:82: note: possible intended match here
==9921==ERROR: AddressSanitizer: SEGV on unknown address 0x000000002056 (pc 0x000000002056 bp 0x000000000001 sp 0x7fff3f230a88 T0)
                                                                                 ^

--
                                                                                                                                                                                                                                                                               
********************                                                                                                                                                                                                                                                           
FAIL: AddressSanitizer-lld-x86_64-linux-dynamic :: TestCases/Linux/globals-gc-sections-lld.cc (255 of 1042)
******************** TEST 'AddressSanitizer-lld-x86_64-linux-dynamic :: TestCases/Linux/globals-gc-sections-lld.cc' FAILED ********************
Script:
--
/build/llvm-build-Clang-release/./bin/clang  --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only  -m64 -fuse-ld=lld  -shared-libasan /build/compiler-rt/test/asan/TestCases/Linux/globals-gc-sections-lld.cc -o /build/llvm-build-Clang-release/projects/compiler-rt/test/asan/LLDX86_64LinuxConfig/TestCases/Linux/Output/globals-gc-sections-lld.cc.tmp -Wl,--gc-sections -fuse-ld=lld -ffunction-sections -fdata-sections -mllvm -asan-globals=0
/build/llvm-build-Clang-release/./bin/clang  --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only  -m64 -fuse-ld=lld  -shared-libasan /build/compiler-rt/test/asan/TestCases/Linux/globals-gc-sections-lld.cc -o /build/llvm-build-Clang-release/projects/compiler-rt/test/asan/LLDX86_64LinuxConfig/TestCases/Linux/Output/globals-gc-sections-lld.cc.tmp -Wl,--gc-sections -fuse-ld=lld -ffunction-sections -fdata-sections -mllvm -asan-globals=1
--
Exit Code: 1

Command Output (stderr):
--
/build/llvm-build-Clang-release/./bin/ld.lld: error: undefined symbol: undefined()
>>> referenced by globals-gc-sections-lld.cc
>>>               /tmp/lit_tmp_M8f31s/globals-gc-sections-lld-83f60d.o:(unused)
clang-6.0: error: linker command failed with exit code 1 (use -v to see invocation)

--

********************
Testing Time: 55.96s
********************
Failing Tests (2):
    AddressSanitizer-lld-x86_64-linux-dynamic :: TestCases/Linux/asan_prelink_test.cc
    AddressSanitizer-lld-x86_64-linux-dynamic :: TestCases/Linux/globals-gc-sections-lld.cc

  Expected Passes    : 766
  Expected Failures  : 2
  Unsupported Tests  : 272
  Unexpected Failures: 2
[35/37] Generating default/Asan-x86_64-inline-Test
FAILED: projects/compiler-rt/test/asan/CMakeFiles/check-asan-dynamic 
cd /build/llvm-build-Clang-release/projects/compiler-rt/test/asan && /usr/bin/python2.7 /build/llvm-build-Clang-release/./bin/llvm-lit -sv /build/llvm-build-Clang-release/projects/compiler-rt/test/asan/X86_64LinuxConfig /build/llvm-build-Clang-release/projects/compiler-rt/test/asan/LLDX86_64LinuxConfig /build/llvm-build-Clang-release/projects/compiler-rt/test/asan/Unit/dynamic
ninja: build stopped: subcommand failed.

[vitalybuka]

test/asan/lit.site.cfg.in

12

Why just asan? can we go for entire compiler-rt?

[lebedev.ri]

test/asan/lit.site.cfg.in

12

I'm not sure what you mean. This is per-sanitizer-config option.
I.e. there is a clang lit config, and a clang lit config with LLD. (and later, with LTO)
I'm not sure how to do that for the entire compiler-rt.

[vitalybuka]

test/asan/lit.site.cfg.in

12

I think we should put it into compiler-rt/test/lit.common.cfg and try to support the option by all sanitizes

[lebedev.ri]

test/asan/lit.site.cfg.in

12

That is great to know, but can you explain in a few more words, please? :)
For the reference, i'm modelling this after CFI - it has several lit configs, with lld&thinlto, just lld, just thinlto, etc.

[vitalybuka]

test/asan/CMakeLists.txt

124

so if complier rt has LLD we are going to run 2x+ as much tests?
cfi has small set of tests, but for entire compiler-rt could be noticeable.
@eugenis, any concerns?

125

if future you are going to add add_asan_testsuite(${arch} True True) call here, right?

test/asan/lit.site.cfg.in

12

please ignore my comment. I've checked patches from description. msan is already done this way

[lebedev.ri]

test/asan/CMakeLists.txt

124

so if complier rt has LLD we are going to run 2x+ as much tests?

I believe so. It has already caught one lld problem (see msan differential), and this diff shows something too.

cfi has small set of tests, but for entire compiler-rt could be noticeable.

Yes, see next comment.

125

Now this is an awesome question. No, i'm serious.
I don't know what will be the best course of action yet.
I do understand that simply mimicking cfi, and having all the combinations will just not work.
I think having something like this in the end may be the best compromise:

add_asan_testsuite(${arch} False False)
add_asan_testsuite(${arch} ${COMPILER_RT_HAS_LLD} True)

i.e. just two combinations - old plain simple; and lld if it is there + lto (thinlto if it is there)

test/asan/lit.site.cfg.in

12

msan is already done this way

And ubsan

test/asan/CMakeLists.txt

 endif()
 set(ASAN_DYNAMIC_TEST_DEPS ${ASAN_TEST_DEPS})
 
 set(ASAN_TEST_ARCH ${ASAN_SUPPORTED_ARCH})
 if(APPLE)
   darwin_filter_host_archs(ASAN_SUPPORTED_ARCH ASAN_TEST_ARCH)
 endif()
 
-foreach(arch ${ASAN_TEST_ARCH})
+macro(add_asan_testsuite arch lld thinlto)
   if(ANDROID)
     set(ASAN_TEST_TARGET_ARCH ${arch}-android)
   else()
     set(ASAN_TEST_TARGET_ARCH ${arch})
   endif()
 
   set(ASAN_TEST_IOS "0")
   pythonize_bool(ASAN_TEST_IOS)
   set(ASAN_TEST_IOSSIM "0")
   pythonize_bool(ASAN_TEST_IOSSIM)
 
+  set(ASAN_TEST_USE_THINLTO ${thinlto})
+  set(ASAN_TEST_USE_LLD ${lld})
+
   string(TOLOWER "-${arch}-${OS_NAME}" ASAN_TEST_CONFIG_SUFFIX)
+  if (${thinlto})
+    set(ASAN_TEST_CONFIG_SUFFIX "-thinlto${ASAN_TEST_CONFIG_SUFFIX}")
+    list(APPEND ASAN_TEST_DEPS LTO)
+  endif()
+  if (${lld})
+    set(ASAN_TEST_CONFIG_SUFFIX "-lld${ASAN_TEST_CONFIG_SUFFIX}")
+    list(APPEND ASAN_TEST_DEPS lld)
+  endif()
+
   get_bits_for_arch(${arch} ASAN_TEST_BITS)
   get_test_cc_for_arch(${arch} ASAN_TEST_TARGET_CC ASAN_TEST_TARGET_CFLAGS)
   if(ANDROID)
     set(ASAN_TEST_DYNAMIC True)
   else()
     set(ASAN_TEST_DYNAMIC False)
   endif()
   string(TOUPPER ${arch} ARCH_UPPER_CASE)
   set(CONFIG_NAME ${ARCH_UPPER_CASE}${OS_NAME}Config)
+  if (${thinlto})
+    set(CONFIG_NAME "thinlto${CONFIG_NAME}")
+    list(APPEND MSAN_TEST_DEPS LTO)
+  endif()
+  if (${lld})
+    set(CONFIG_NAME "LLD${CONFIG_NAME}")
+    list(APPEND MSAN_TEST_DEPS lld)
+  endif()
   configure_lit_site_cfg(
     ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in
     ${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME}/lit.site.cfg
     )
   list(APPEND ASAN_TESTSUITES ${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME})
 
   if(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME)
     string(TOLOWER "-${arch}-${OS_NAME}-dynamic" ASAN_TEST_CONFIG_SUFFIX)
+    if (${thinlto})
+      set(ASAN_TEST_CONFIG_SUFFIX "-thinlto${ASAN_TEST_CONFIG_SUFFIX}")
+      list(APPEND ASAN_TEST_DEPS LTO)
+    endif()
+    if (${lld})
+      set(ASAN_TEST_CONFIG_SUFFIX "-lld${ASAN_TEST_CONFIG_SUFFIX}")
+      list(APPEND ASAN_TEST_DEPS lld)
+    endif()
     set(ASAN_TEST_DYNAMIC True)
     set(CONFIG_NAME ${ARCH_UPPER_CASE}${OS_NAME}DynamicConfig)
+    set(CONFIG_NAME ${ARCH_UPPER_CASE}${OS_NAME}Config)
+    if (${thinlto})
+      set(CONFIG_NAME "thinlto${CONFIG_NAME}")
+      list(APPEND MSAN_TEST_DEPS LTO)
+    endif()
+    if (${lld})
+      set(CONFIG_NAME "LLD${CONFIG_NAME}")
+      list(APPEND MSAN_TEST_DEPS lld)
+    endif()
     configure_lit_site_cfg(
       ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in
       ${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME}/lit.site.cfg)
     list(APPEND ASAN_DYNAMIC_TESTSUITES
       ${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME})
   endif()
+endmacro()
+
+foreach(arch ${ASAN_TEST_ARCH})
+  add_asan_testsuite(${arch} False False)
+
+  if(COMPILER_RT_HAS_LLD AND arch STREQUAL "x86_64" AND NOT (APPLE OR WIN32))
+    add_asan_testsuite(${arch} True False)
+  endif()
 endforeach()
 
 # iOS and iOS simulator test suites
 # These are not added into "check-all", in order to run these tests, use
 # "check-asan-iossim-x86_64" and similar. They also require that an extra env
 # variable to select which iOS device or simulator to use, e.g.:
 # SANITIZER_IOSSIM_TEST_DEVICE_IDENTIFIER="iPhone 6"
 if(APPLE)
   set(EXCLUDE_FROM_ALL ON)
 
   set(ASAN_TEST_TARGET_CC ${COMPILER_RT_TEST_COMPILER})
   set(ASAN_TEST_IOS "1")
   pythonize_bool(ASAN_TEST_IOS)
   set(ASAN_TEST_DYNAMIC True)
+  set(ASAN_TEST_USE_THINLTO FALSE)
+  set(ASAN_TEST_USE_LLD FALSE)
 
   foreach(arch ${DARWIN_iossim_ARCHS})
     set(ASAN_TEST_IOSSIM "1")
     pythonize_bool(ASAN_TEST_IOSSIM)
     set(ASAN_TEST_TARGET_ARCH ${arch})
     set(ASAN_TEST_TARGET_CFLAGS "-arch ${arch} -isysroot ${DARWIN_iossim_SYSROOT} ${COMPILER_RT_TEST_COMPILER_CFLAGS}")
     set(ASAN_TEST_CONFIG_SUFFIX "-${arch}-iossim")
     get_bits_for_arch(${arch} ASAN_TEST_BITS)

test/asan/lit.site.cfg.in

 @LIT_SITE_CFG_IN_HEADER@
 
 # Tool-specific config options.
 config.name_suffix = "@ASAN_TEST_CONFIG_SUFFIX@"
 config.target_cflags = "@ASAN_TEST_TARGET_CFLAGS@"
 config.clang = "@ASAN_TEST_TARGET_CC@"
 config.bits = "@ASAN_TEST_BITS@"
 config.ios = @ASAN_TEST_IOS_PYBOOL@
 config.iossim = @ASAN_TEST_IOSSIM_PYBOOL@
 config.asan_dynamic = @ASAN_TEST_DYNAMIC@
 config.target_arch = "@ASAN_TEST_TARGET_ARCH@"
+config.use_lld = @ASAN_TEST_USE_LLD@
+config.use_thinlto = @ASAN_TEST_USE_THINLTO@
 
 # Load common config for all compiler-rt lit tests.
 lit_config.load_config(config, "@COMPILER_RT_BINARY_DIR@/test/lit.common.configured")
 
 # Load tool-specific config that would do the real work.
 lit_config.load_config(config, "@ASAN_LIT_SOURCE_DIR@/lit.cfg")