This is an archive of the discontinued LLVM Phabricator instance.

[DWARFv5] Dump MD5 checksum from line-table header
ClosedPublic

Authored by probinson on Dec 11 2017, 1:13 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

probinson created this revision.Dec 11 2017, 1:13 PM
aprantl accepted this revision.Dec 15 2017, 10:02 AM

sgtm. some formatting comments inline.

llvm/lib/CodeGen/AsmPrinter/DIE.cpp
780 ↗(On Diff #126433)

for consistency with the surrounding code, perhaps all on one line?

797 ↗(On Diff #126433)

same here?

This revision is now accepted and ready to land.Dec 15 2017, 10:02 AM
This revision was automatically updated to reflect the committed changes.
probinson marked 2 inline comments as done.
probinson added inline comments.Dec 15 2017, 11:53 AM
llvm/lib/CodeGen/AsmPrinter/DIE.cpp
780 ↗(On Diff #126433)

I agree. clang-format did this, but clearly it wants one line per case.

797 ↗(On Diff #126433)

Same here.