Page MenuHomePhabricator

[ARM] Register the Thumb2SizeReducePass
ClosedPublic

Authored by dmgreen on Dec 11 2017, 10:58 AM.

Details

Reviewers
eastig
Summary

To allow llc to refer to it.

Diff Detail

Event Timeline

dmgreen created this revision.Dec 11 2017, 10:58 AM
dmgreen updated this revision to Diff 127327.Dec 18 2017, 4:04 AM

Added example test.

eastig added a subscriber: eastig.Dec 18 2017, 4:19 AM
eastig added inline comments.
lib/Target/ARM/Thumb2SizeReduction.cpp
166

Why do we need an empty function by default?

Thanks for taking a look.

lib/Target/ARM/Thumb2SizeReduction.cpp
166

INITIALIZE_PASS expects it to be default constructable.

As createThumb2SizeReductionPass already acts this same way (has a nullptr default argument), it's already able to handle null arguments here.

eastig accepted this revision.Dec 18 2017, 5:17 AM

LGTM

This revision is now accepted and ready to land.Dec 18 2017, 5:17 AM