This is an archive of the discontinued LLVM Phabricator instance.

Paths

Fix test/msan/iconv.cc on NetBSD
ClosedPublic

Authored by krytarowski on Dec 8 2017, 8:59 AM.

Reviewers

Commits

Summary

NetBSD still uses the old POSIX iconv(3) signature with the 2nd const argument.

vitalybuka added inline comments.

test/msan/iconv.cc
19	line is too long

This revision is now accepted and ready to land.Dec 8 2017, 3:52 PM

test/msan/iconv.cc
19	I will commit it as `Some OSes expect the 2nd argument of iconv(3) to be of type const char **`

This revision was automatically updated to reflect the committed changes.

Path

Size

test/

msan/

4 lines

	Show All 9 Lines

	int main(void) {			int main(void) {
	iconv_t cd = iconv_open("ASCII", "ASCII");			iconv_t cd = iconv_open("ASCII", "ASCII");
	assert(cd != (iconv_t)-1);			assert(cd != (iconv_t)-1);

	char inbuf_[100];			char inbuf_[100];
	strcpy(inbuf_, "sample text");			strcpy(inbuf_, "sample text");
	char outbuf_[100];			char outbuf_[100];
	#if defined(__FreeBSD__)			#if defined(__FreeBSD__) \|\| defined(__NetBSD__)
	// FreeBSD's iconv() expects the 2nd argument be of type 'const char**'.			// Due to old POSIX mistake some OSes expect 2nd argument of iconv() to be of type 'const char**'.
				vitalybukaUnsubmitted Not Done Reply Inline Actions line is too long vitalybuka: line is too long
				krytarowskiAuthorUnsubmitted Not Done Reply Inline Actions I will commit it as `Some OSes expect the 2nd argument of iconv(3) to be of type const char ` krytarowski: I will commit it as `Some OSes expect the 2nd argument of iconv(3) to be of type const char `
	const char *inbuf = inbuf_;			const char *inbuf = inbuf_;
	#else			#else
	char *inbuf = inbuf_;			char *inbuf = inbuf_;
	#endif			#endif
	char *outbuf = outbuf_;			char *outbuf = outbuf_;
	size_t inbytesleft = strlen(inbuf_);			size_t inbytesleft = strlen(inbuf_);
	size_t outbytesleft = sizeof(outbuf_);			size_t outbytesleft = sizeof(outbuf_);

	Show All 26 Lines