This is an archive of the discontinued LLVM Phabricator instance.

Fix test/msan/iconv.cc on NetBSD
ClosedPublic

Authored by krytarowski on Dec 8 2017, 8:59 AM.

Details

Summary

NetBSD still uses the old POSIX iconv(3) signature with the 2nd const argument.

Sponsored by <The NetBSD Foundation>

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski created this revision.Dec 8 2017, 8:59 AM
vitalybuka accepted this revision.Dec 8 2017, 3:52 PM
vitalybuka added inline comments.
test/msan/iconv.cc
19

line is too long

This revision is now accepted and ready to land.Dec 8 2017, 3:52 PM
krytarowski added inline comments.Dec 8 2017, 4:41 PM
test/msan/iconv.cc
19

I will commit it as Some OSes expect the 2nd argument of iconv(3) to be of type const char **

This revision was automatically updated to reflect the committed changes.