[libunwind] Use the correct variable name for target triple in lit

[phosek]

Summary

The variable representing target triple in libunwind is named
LIBUNWIND_TARGET_TRIPLE, not TARGET_TRIPLE.

[jroelofs]

There's a: set(TARGET_TRIPLE ...) in each of these runtimes' CMakeLists.txt...

[jroelofs]

(i.e. you should delete that, since this is the last dependency on it AFAICT)

[phosek]

Actually it seems to be missing in libunwind, but I see it in libc++abi and libc++ (I missed that one). Do you want me to remove it from those two or add it to libunwind? It's a little strange to be using both LIBUNWIND_TARGET_TRIPLE and TARGET_TRIPLE in the same file.

[jroelofs]

I think just remove it from them.

[compnerd]

I'm okay with this change in principle, but Im worried that this may break the buildbots. Please ensure that they remain green after this change.

[phosek]

After some more digging through libc++ test suite, I think I understand now why these are different variables. It may be possible to remove these and just rely on plain CMake variables but this is likely going to require some more CMake and lit surgery, so for now I'm going to land D40820 which is an alternative solution and revisit this later after I cleanup libc++ test suite.

[phosek]

This is no longer needed after D57670 landed.

test/lit.site.cfg.in

 config.use_sanitizer            = "@LLVM_USE_SANITIZER@"
 config.enable_32bit             = "@LIBUNWIND_BUILD_32_BITS@"
 config.target_info              = "@LIBUNWIND_TARGET_INFO@"
 config.executor                 = "@LIBUNWIND_EXECUTOR@"
 config.libunwind_shared         = "@LIBUNWIND_ENABLE_SHARED@"
 config.enable_shared            = "@LIBCXX_ENABLE_SHARED@"
 config.enable_exceptions        = "@LIBUNWIND_ENABLE_EXCEPTIONS@"
 config.host_triple              = "@LLVM_HOST_TRIPLE@"
-config.target_triple            = "@TARGET_TRIPLE@"
+config.target_triple            = "@LIBUNWIND_TARGET_TRIPLE@"
 config.use_target               = len("@LIBUNWIND_TARGET_TRIPLE@") > 0
 config.cxx_ext_threads          = "@LIBUNWIND_BUILD_EXTERNAL_THREAD_LIBRARY@"
 
 # Let the main config do the real work.
 lit_config.load_config(config, "@LIBUNWIND_SOURCE_DIR@/test/lit.cfg")