[dsymutil] Add -verify option to run DWARF verifier after linking.
ClosedPublic

Authored by JDevlieghere on Sun, Dec 3, 12:57 PM.

Details

Summary

This patch adds support for running the DWARF verifier on the linked
debug info files. If the -verify options is specified and verification
fails, dsymutil exists with abort with non-zero exit code. This behavior
is *not* enabled by default.

Diff Detail

Repository
rL LLVM
JDevlieghere created this revision.Sun, Dec 3, 12:57 PM
vsk accepted this revision.Mon, Dec 4, 12:03 PM

Looks good to me.

test/tools/dsymutil/X86/verify.test
4 ↗(On Diff #125294)

Why are the copies needed?

This revision is now accepted and ready to land.Mon, Dec 4, 12:03 PM
probinson added inline comments.
tools/dsymutil/dsymutil.cpp
105 ↗(On Diff #125294)

This looks like an unrelated formatting change?
Also later on a couple of extra blank lines were removed. I'm guessing you ran clang-format on the whole file instead of using clang-format-diff. Generally we prefer whitespace/formatting changes to be done separately from functional changes.

JDevlieghere marked 2 inline comments as done.Tue, Dec 5, 8:23 AM
JDevlieghere added inline comments.
test/tools/dsymutil/X86/verify.test
4 ↗(On Diff #125294)

Thanks! I had copied this from another test where the flat mode mattered and output was written to the temp folder. It's not necessary for this test so we don't need the copies.

tools/dsymutil/dsymutil.cpp
105 ↗(On Diff #125294)

Jup, this was unintentional. In addition to git clang-format before uploading the patch, I usually format new code in my editor by visually selecting it. However if you're in normal mode, it formats the whole file which is what must have happened here.

JDevlieghere marked 2 inline comments as done.
aprantl added inline comments.Tue, Dec 5, 9:21 AM
tools/dsymutil/dsymutil.cpp
210 ↗(On Diff #125535)

should this be gated by --verbose ?

JDevlieghere marked an inline comment as done.
aprantl accepted this revision.Wed, Dec 6, 9:11 AM
This revision was automatically updated to reflect the committed changes.