Page MenuHomePhabricator

[libcxx] Add underscores to win32 locale headers.
AbandonedPublic

Authored by halyavin on Dec 3 2017, 5:46 AM.

Details

Summary

Avoid possible collisions with macros.

Diff Detail

Event Timeline

halyavin created this revision.Dec 3 2017, 5:46 AM
jroelofs added inline comments.
src/support/win32/locale_win32.cpp
90

__ap

99

__ap

101

s.result.__res.

halyavin updated this revision to Diff 125354.Dec 4 2017, 9:30 AM
halyavin marked 3 inline comments as done.

looks fine to me, but this is the sort of thing that @EricWF usually wants the final say on.

@EricWF , could you please look at this change? It doesn't have any functional changes.

halyavin updated this revision to Diff 137945.Mar 11 2018, 6:32 AM

update to new revision

We don't usually do this in source files, because they don't get included in people's builds - just the library build.

if you look in src/mutex.cpp, you'll see stuff like:
void __call_once(volatile unsigned long& flag, void* arg, void(*func)(void*))

On the other hand, if you are seeing a conflict, then we can apply this.

halyavin abandoned this revision.Apr 25 2018, 1:45 AM