halyavin (Andrey Khalyavin)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 24 2016, 4:25 AM (86 w, 4 d)

Recent Activity

Mar 11 2018

halyavin added a comment to D40775: [libcxx] Add underscores to win32 locale headers..

ping.

Mar 11 2018, 6:34 AM
halyavin updated the diff for D40775: [libcxx] Add underscores to win32 locale headers..

update to new revision

Mar 11 2018, 6:34 AM

Dec 13 2017

halyavin added a comment to D40775: [libcxx] Add underscores to win32 locale headers..

@EricWF , could you please look at this change? It doesn't have any functional changes.

Dec 13 2017, 12:16 PM

Dec 5 2017

halyavin added a comment to D40774: [libcxx] Fix intrinsics for MSVC.

Are you actually using libc++ with cl? :)

People mostly use it to compile on Windows but I heard someone launches the result too. Since no one complains and it passed most of the testing, I guess the result doesn't explode. It is also part of catboost but I haven't tried how well it works there myself yet.

Hmm how is #include_next handled?

Dec 5 2017, 9:39 AM

Dec 4 2017

halyavin added a comment to D40774: [libcxx] Fix intrinsics for MSVC.

Are you actually using libc++ with cl? :)

Dec 4 2017, 11:24 PM
halyavin added inline comments to D40071: [libcxx] Implement exception_ptr on Windows without msvcprt.dll.
Dec 4 2017, 11:03 PM
halyavin updated the diff for D40071: [libcxx] Implement exception_ptr on Windows without msvcprt.dll.

Updated diff to include whole context.

Dec 4 2017, 9:32 AM
halyavin updated the diff for D40775: [libcxx] Add underscores to win32 locale headers..
Dec 4 2017, 9:30 AM

Dec 3 2017

halyavin created D40775: [libcxx] Add underscores to win32 locale headers..
Dec 3 2017, 5:46 AM
halyavin created D40774: [libcxx] Fix intrinsics for MSVC.
Dec 3 2017, 3:03 AM

Nov 23 2017

halyavin added a comment to D40181: [libcxx] Allow to set locale on Windows..

@EricWF, could you please commit this change?

Nov 23 2017, 2:27 AM

Nov 22 2017

halyavin updated the diff for D40181: [libcxx] Allow to set locale on Windows..
Nov 22 2017, 5:47 AM
halyavin added a comment to D40181: [libcxx] Allow to set locale on Windows..
(but I think it does define some sort of dummy functions that at least will allow it to build)

Looked into MinGW-w64 sources and this is indeed the case. _configthreadlocale will return -1 and will not do anything.

Nov 22 2017, 5:45 AM
halyavin updated the diff for D40181: [libcxx] Allow to set locale on Windows..

Fixed problem with C++98, added std for nullptr_t and switched on _l functions for MinGW.

Nov 22 2017, 5:39 AM

Nov 18 2017

halyavin retitled D40210: [libc++] Shrink variant's index type when possible from [libc++] Shrink varient's index type when possible to [libc++] Shrink variant's index type when possible.
Nov 18 2017, 12:56 PM

Nov 17 2017

halyavin created D40181: [libcxx] Allow to set locale on Windows..
Nov 17 2017, 9:34 AM

Nov 16 2017

halyavin removed a reviewer for D40071: [libcxx] Implement exception_ptr on Windows without msvcprt.dll: EricFowler.
Nov 16 2017, 4:01 AM

Nov 15 2017

halyavin created D40071: [libcxx] Implement exception_ptr on Windows without msvcprt.dll.
Nov 15 2017, 4:37 AM
halyavin updated the diff for D39962: [libcxx] Fix current_exception test on Windows..

Add lower bound too.

Nov 15 2017, 3:21 AM

Nov 13 2017

halyavin created D39962: [libcxx] Fix current_exception test on Windows..
Nov 13 2017, 8:47 AM
halyavin created D39961: [libcxx] Fix rethrow_if_nested test on Windows..
Nov 13 2017, 8:38 AM

Jul 17 2017

halyavin added a comment to D32411: [libcxx] Provide #include_next alternative for MSVC.

@smeenai wrote:

This is kinda ugly, but I can't think of a better way to do it. I'm fine with this, but given that it's a pretty invasive change, I'm not comfortable accepting. You may wanna ping @EricWF and @mclow.lists directly.

I'll be meeting with the MS compiler engineers next week; I'll see when/if they plan on implemementing include_next.

Jul 17 2017, 5:36 AM

May 3 2017

halyavin added a comment to D32349: Summary: Fix race condition in std::atomic_store for std::shared_ptr..

Thank you. Could you commit this patch for me?

May 3 2017, 11:51 PM
halyavin added a comment to D32349: Summary: Fix race condition in std::atomic_store for std::shared_ptr..

Unfortunately, I can't write deterministic test.

May 3 2017, 1:59 PM
halyavin added a comment to D32349: Summary: Fix race condition in std::atomic_store for std::shared_ptr..

ping

May 3 2017, 1:20 PM

Apr 24 2017

halyavin added a comment to D32411: [libcxx] Provide #include_next alternative for MSVC.

BTW, the list of include files which are located in [PROGRAM_FILES]\Microsoft Visual Studio 14.0\VC\include directory is

Apr 24 2017, 2:10 AM

Apr 23 2017

halyavin added a comment to D32411: [libcxx] Provide #include_next alternative for MSVC.

Here is how we solved this problem in our libc++ fork:

Apr 23 2017, 9:39 PM
halyavin retitled D32349: Summary: Fix race condition in std::atomic_store for std::shared_ptr. from Summary: Fix race condition is std::atomic_store for std::shared_ptr. to Summary: Fix race condition in std::atomic_store for std::shared_ptr..
Apr 23 2017, 11:35 AM

Apr 21 2017

halyavin created D32349: Summary: Fix race condition in std::atomic_store for std::shared_ptr..
Apr 21 2017, 6:47 AM

Mar 10 2017

halyavin added a comment to D30837: [libcxx] Support for shared_ptr<T()>.

But std::allocator<void> is deprecated in C++17. I don't know a good solution, I just used int as an arbitrary type when I faced similar problem.

Mar 10 2017, 11:22 AM

Feb 3 2017

halyavin added a comment to D29389: Fix compile error for Visual Studio 2015 / cl compiler..

If you are satisfied with the test too, could you please commit this change for me?

Feb 3 2017, 7:03 AM
halyavin updated the summary of D29389: Fix compile error for Visual Studio 2015 / cl compiler..
Feb 3 2017, 7:02 AM
halyavin added a comment to D29389: Fix compile error for Visual Studio 2015 / cl compiler..

Ah, I misunderstood what _PackExpandsToThisTuple does. I added test that excises the case where it is needed.

Feb 3 2017, 2:18 AM
halyavin updated the summary of D29389: Fix compile error for Visual Studio 2015 / cl compiler..
Feb 3 2017, 2:17 AM
halyavin updated the diff for D29389: Fix compile error for Visual Studio 2015 / cl compiler..

Add test for _PackExpandsToThisTuple in reduce arity constructor.

Feb 3 2017, 2:14 AM

Feb 2 2017

halyavin added a comment to D29389: Fix compile error for Visual Studio 2015 / cl compiler..

*this condition -> _PackExpandsToThisTuple<_Up...>

Feb 2 2017, 7:43 AM
halyavin added a comment to D29389: Fix compile error for Visual Studio 2015 / cl compiler..

Since there is no mistake here, I can't make the test to fail before the change. Or do you just need a test that invokes this code path? It looks like test/libcxx/utilities/tuple/tuple.tuple/tuple.cnstr/disable_reduced_arity_initialization_extension.pass.cpp already does the job. If I replace !_PackExpandsToThisTuple<_Up...>() with false, it fails.

Feb 2 2017, 7:42 AM
halyavin added a comment to D29389: Fix compile error for Visual Studio 2015 / cl compiler..

Ah, I see - there is no mistake here. It is Visual Studio 2015 cl compiler that doesn't have full support for constexpr function calls inside template arguments. I have substantially changed tuple header to avoid such calls and your revision just introduced another one.

Feb 2 2017, 5:04 AM
halyavin retitled D29389: Fix compile error for Visual Studio 2015 / cl compiler. from Fix compile error in tuple. to Fix compile error for Visual Studio 2015 / cl compiler..
Feb 2 2017, 4:56 AM

Feb 1 2017

halyavin created D29389: Fix compile error for Visual Studio 2015 / cl compiler..
Feb 1 2017, 4:03 AM

Jan 7 2017

halyavin added inline comments to D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows.
Jan 7 2017, 4:55 AM
halyavin added inline comments to D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows.
Jan 7 2017, 4:31 AM
halyavin added inline comments to D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows.
Jan 7 2017, 4:05 AM
halyavin added inline comments to D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows.
Jan 7 2017, 3:53 AM

Jan 6 2017

halyavin added inline comments to D28441: [libc++] [CMake] Link with /nodefaultlibs on Windows.
Jan 6 2017, 11:41 PM
halyavin added a comment to D28220: provide Win32 native threading.

LGTM.

Jan 6 2017, 2:38 PM

Jan 5 2017

halyavin added inline comments to D28220: provide Win32 native threading.
Jan 5 2017, 12:46 PM

Jan 4 2017

halyavin added inline comments to D28220: provide Win32 native threading.
Jan 4 2017, 11:35 PM
halyavin added inline comments to D28220: provide Win32 native threading.
Jan 4 2017, 1:49 AM

Jan 3 2017

halyavin added inline comments to D28220: provide Win32 native threading.
Jan 3 2017, 1:36 PM

Jan 1 2017

halyavin abandoned D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning..
Jan 1 2017, 10:32 AM

Dec 21 2016

halyavin added a comment to D27915: Add missing includes on Windows..

ping

Dec 21 2016, 10:57 AM

Dec 19 2016

halyavin added a comment to D27915: Add missing includes on Windows..

Could you please commit this change? I don't have commit access.

Dec 19 2016, 9:51 PM
halyavin updated D27915: Add missing includes on Windows..
Dec 19 2016, 9:50 PM
halyavin added a comment to D27915: Add missing includes on Windows..
  • _byteswap_* needs stdlib.h
  • _CrtSetReportHook needs crtdbg.h
Dec 19 2016, 1:16 AM
halyavin retitled D27915: Add missing includes on Windows. from to Add missing includes on Windows..
Dec 19 2016, 1:14 AM

Dec 9 2016

halyavin added a comment to D27517: [libcxx] Add missing const..

Could you please commit this change? I don't have commit access.

Dec 9 2016, 3:59 AM
halyavin retitled D27517: [libcxx] Add missing const. from Add missing const. to [libcxx] Add missing const..
Dec 9 2016, 3:59 AM

Dec 8 2016

halyavin updated the diff for D27517: [libcxx] Add missing const..

Remove space changes on line ends in include/set.

Dec 8 2016, 12:59 AM
halyavin updated the diff for D27517: [libcxx] Add missing const..

Update test to check that count() works with const container.

Dec 8 2016, 12:51 AM

Dec 7 2016

halyavin retitled D27517: [libcxx] Add missing const. from to Add missing const..
Dec 7 2016, 5:07 AM

Sep 27 2016

halyavin updated subscribers of D24991: Inline hot functions in libcxx shared_ptr implementation..
Sep 27 2016, 11:07 PM

Sep 5 2016

halyavin added a comment to D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning..

False alarm. I figured out that only -Wattributes warnings ignore gcc system_header pragma. So this -Wcast-qual and other warnings doesn't block us.

Sep 5 2016, 5:57 AM

Aug 30 2016

halyavin added a comment to D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning..

! In D23831#528668, @EricWF wrote:

Are you also compiling with -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER?

Aug 30 2016, 4:19 AM
halyavin added a comment to D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning..

We have libc++ in our source tree and compile it as part of our build process. All code in the source tree uses -Werror by default, so I am having compile errors on gcc 4.9.

Aug 30 2016, 3:17 AM
halyavin added a comment to D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning..

Thank you for fixing most of warnings. Now it says "cc1plus: warning: unrecognized command line option "-Wno-c++14-compat"" though.

Aug 30 2016, 2:48 AM

Aug 27 2016

halyavin added a comment to D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning..

ping.

Aug 27 2016, 10:18 AM

Aug 24 2016

halyavin retitled D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning. from Fix gcc 4.9 -Wcast-qual warning. to [libcxx] Fix gcc 4.9 -Wcast-qual warning..
Aug 24 2016, 4:45 AM
halyavin retitled D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning. from to Fix gcc 4.9 -Wcast-qual warning..
Aug 24 2016, 4:40 AM