This is an archive of the discontinued LLVM Phabricator instance.

New users should be using the runtimes dir, not projects
AbandonedPublic

Authored by jroelofs on Dec 1 2017, 8:46 AM.

Details

Reviewers
beanz
echristo
Summary

Somewhat tangentially, is it time to deprecate building them from the projects dir?

Diff Detail

Event Timeline

jroelofs created this revision.Dec 1 2017, 8:46 AM
beanz accepted this revision.Dec 1 2017, 9:54 AM

The docs changes look good to me. I think if we want to deprecate llvm/projects for runtime libraries, we should have a discussion on llvm-dev & cfe-dev. I think too few people are using llvm/runtimes today as part of their regular builds for me to feel comfortable deprecating llvm/projects without giving some notice first and getting more people to try the runtimes directory.

This revision is now accepted and ready to land.Dec 1 2017, 9:54 AM

You should also update the test-release.sh script to use this new convention.

The docs changes look good to me. I think if we want to deprecate llvm/projects for runtime libraries, we should have a discussion on llvm-dev & cfe-dev. I think too few people are using llvm/runtimes today as part of their regular builds for me to feel comfortable deprecating llvm/projects without giving some notice first and getting more people to try the runtimes directory.

Yeah, wasn't proposing hashing that out in this thread. Definitely agree.

You should also update the test-release.sh script to use this new convention.

Good call! I'll do that in another patch. Might take a week or so for me to get some spare cycles to do that.

jroelofs abandoned this revision.Apr 1 2020, 10:40 AM