Clang 5 or higher adds an intermediate function call in certain cases when compiling with debug flag. This revision updates the testcases to work correctly.
Details
Details
- Reviewers
protze.joachim Hahnfeld jlpeyton - Commits
- rG0e2a2571ca46: [OMPT] Use frames at different level when using clang version 5 or higher with…
rL321263: [OMPT] Use frames at different level when using clang version 5 or higher with…
rOMP321263: [OMPT] Use frames at different level when using clang version 5 or higher with…
Diff Detail
Diff Detail
- Repository
- rOMP OpenMP
Event Timeline
Comment Actions
(note: please post full context information as described in https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)
runtime/test/ompt/callback.h | ||
---|---|---|
74 | I propose to always issue this warning: The test will also fail if the user specifies -DDEBUG without -g. In normal testing with lit, this won't do any harm because stderr is filtered away if the test is successful. |
Comment Actions
Just had a more thorough look at the tests which include all kinds of outlined functions. I previously suggested print_frame_in_task() because I thought Clang would only wrap the function for tasks. Maybe print_frame_from_outlined_fn() would be a better name after all?
runtime/test/ompt/parallel/nested.c | ||
---|---|---|
28–29 | This should use the new macro |
I propose to always issue this warning: The test will also fail if the user specifies -DDEBUG without -g. In normal testing with lit, this won't do any harm because stderr is filtered away if the test is successful.