This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] Support building libunwind as a DLL
ClosedPublic

Authored by mstorsjo on Nov 27 2017, 3:49 AM.

Diff Detail

Event Timeline

mstorsjo created this revision.Nov 27 2017, 3:49 AM
compnerd accepted this revision.Nov 28 2017, 9:27 PM

LG with the adjustment for the dll storage macros.

CMakeLists.txt
313

Ugh, I really do dislike the _LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS macro, but that isn't your fault.

src/config.h
53

I think that !defined(__ELF__) && !defined(__MACHO__) is better than defined(_WIN32), as these are PE/COFF specific, not Windows specification.

This revision is now accepted and ready to land.Nov 28 2017, 9:27 PM
mstorsjo added inline comments.Nov 28 2017, 9:52 PM
src/config.h
53

Ok, I can make it use that instead. libcxx and libcxxabi do use defined(_WIN32) in their similar checks though.

This revision was automatically updated to reflect the committed changes.