Warning is emitted when tiles are requested but cannot be used

[omalyshe]

Summary

Added two warnings:

before building the topology map check if tiles are requested but the topo method is not hwloc;

after building the topology map check if tiles are requested but not detected by the library.

[tlwilmar]

LGTM

[ismail]

Hi, this fails to build (Linux x86-64):

../projects/openmp/runtime/src/kmp_affinity.cpp:3852:30: error: use of undeclared identifier 'affinity_gran_tile'; did you mean 'affinity_gran_fine'?                                         
  if (__kmp_affinity_gran == affinity_gran_tile &&
                             ^~~~~~~~~~~~~~~~~~
                             affinity_gran_fine
../projects/openmp/runtime/src/kmp.h:702:3: note: 'affinity_gran_fine' declared here
  affinity_gran_fine = 0,
  ^
../projects/openmp/runtime/src/kmp_affinity.cpp:4125:30: error: use of undeclared identifier 'affinity_gran_tile'; did you mean 'affinity_gran_fine'?                                         
  if (__kmp_affinity_gran == affinity_gran_tile && __kmp_tile_depth == 0) {
                             ^~~~~~~~~~~~~~~~~~
                             affinity_gran_fine
../projects/openmp/runtime/src/kmp.h:702:3: note: 'affinity_gran_fine' declared here
  affinity_gran_fine = 0,
  ^
../projects/openmp/runtime/src/kmp_affinity.cpp:4125:52: error: use of undeclared identifier '__kmp_tile_depth'; did you mean '__kmp_aff_depth'?                                              
  if (__kmp_affinity_gran == affinity_gran_tile && __kmp_tile_depth == 0) {
                                                   ^~~~~~~~~~~~~~~~
                                                   __kmp_aff_depth
../projects/openmp/runtime/src/kmp_affinity.cpp:3777:12: note: '__kmp_aff_depth' declared here
static int __kmp_aff_depth = 0;
           ^
3 errors generated.

[AndreyChurbanov]

I've just committed the related patch https://reviews.llvm.org/D40309 that should fix the build problem.

We should have set the dependencies between these patches initially to avoid this kind of problems...

openmp/trunk/runtime/src/i18n/en_US.txt

 # --------------------------------------------------------------------------------------------------
 
 # Meta information about message catalog.
 
 Language "English"
 Country  "USA"
 LangId   "1033"
 Version  "2"
-Revision "20170327"
+Revision "20170523"
 
 
 
 # --------------------------------------------------------------------------------------------------
 -*- STRINGS -*-
 # --------------------------------------------------------------------------------------------------
 
 # Strings are not complete messages, just fragments. We need to work on it and reduce number of

 BarriersInDifferentOrder     "Threads encountered barriers in different order. "
 FunctionError                "Function %1$s failed:"
 TopologyExtra                "%1$s: %2$s packages x %3$d cores/pkg x %4$d threads/core (%5$d total cores)"
 WrongMessageCatalog          "Incompatible message catalog \"%1$s\": Version \"%2$s\" found, version \"%3$s\" expected."
 StgIgnored                   "%1$s: ignored because %2$s has been defined"
                                  # %1, -- name of ignored variable, %2 -- name of variable with higher priority.
 OBSOLETE                     "%1$s: overrides %3$s specified before"
                                  # %1, %2 -- name and value of the overriding variable, %3 -- name of overriden variable.
+AffTilesNoHWLOC              "%1$s: Tiles are only supported if KMP_TOPOLOGY_METHOD=hwloc, using granularity=package instead"
+AffTilesNoTiles              "%1$s: Tiles requested but were not detected on this HW, using granularity=package instead"
 OmptOutdatedWorkshare        "OMPT: Cannot determine workshare type; using the default (loop) instead. "
                              "This issue is fixed in an up-to-date compiler."
 
 # --- OpenMP errors detected at runtime ---
 #
 #    %1 is the name of OpenMP construct (formatted with "Pragma" format).
 #
 CnsBoundToWorksharing        "%1$s must be bound to a work-sharing or work-queuing construct with an \"ordered\" clause"

openmp/trunk/runtime/src/kmp_affinity.cpp

if (__kmp_affinity_respect_mask) {
         return;
       }
     } else {
       __kmp_affinity_entire_machine_mask(__kmp_affin_fullMask);
       __kmp_avail_proc = __kmp_xproc;
     }
   }
 
+  if (__kmp_affinity_gran == affinity_gran_tile &&
+      // check if user's request is valid
+      __kmp_affinity_dispatch->get_api_type() == KMPAffinity::NATIVE_OS) {
+    KMP_WARNING(AffTilesNoHWLOC, "KMP_AFFINITY");
+    __kmp_affinity_gran = affinity_gran_package;
+  }
+
   int depth = -1;
   kmp_i18n_id_t msg_id = kmp_i18n_null;
 
   // For backward compatibility, setting KMP_CPUINFO_FILE =>
   // KMP_TOPOLOGY_METHOD=cpuinfo
   if ((__kmp_cpuinfo_file != NULL) &&
       (__kmp_affinity_top_method == affinity_top_method_all)) {
     __kmp_affinity_top_method = affinity_top_method_cpuinfo;
if (KMP_AFFINITY_CAPABLE() &&
          (__kmp_affinity_warnings && (__kmp_affinity_type != affinity_none)))) {
       KMP_WARNING(ErrorInitializeAffinity);
     }
     __kmp_affinity_type = affinity_none;
     KMP_AFFINITY_DISABLE();
     return;
   }
 
+  if (__kmp_affinity_gran == affinity_gran_tile && __kmp_tile_depth == 0) {
+    // tiles requested but not detected, warn user on this
+    KMP_WARNING(AffTilesNoTiles, "KMP_AFFINITY");
+  }
+
   __kmp_apply_thread_places(&address2os, depth);
 
   // Create the table of masks, indexed by thread Id.
   unsigned maxIndex;
   unsigned numUnique;
   kmp_affin_mask_t *osId2Mask =
       __kmp_create_masks(&maxIndex, &numUnique, address2os, __kmp_avail_proc);
   if (__kmp_affinity_gran_levels == 0) {