This is an archive of the discontinued LLVM Phabricator instance.

[LLD] [MinGW] Ignore the --build-id, --pie-executable and --disable-auto-image-base options
ClosedPublic

Authored by mstorsjo on Nov 14 2017, 8:30 AM.

Details

Summary

LLD already writes a build id if debug info is enabled.

Some projects set --pie-executable to avoid GNU ld bugs about stripping base relocations from an executable when they actually are used. Since -fixed:no is the default (and we don't support setting the -fixed option via the MinGW frontend), we don't need to handle this.

--disable-auto-image-base is ignored just like --enable-auto-image-base (as we ignore from before).

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Nov 14 2017, 8:30 AM
rnk accepted this revision.Nov 14 2017, 1:40 PM

lgtm

This revision is now accepted and ready to land.Nov 14 2017, 1:40 PM
ruiu accepted this revision.Nov 14 2017, 11:21 PM

LGTM

This revision was automatically updated to reflect the committed changes.