Page MenuHomePhabricator

Remove extra minuses from command option
ClosedPublic

Authored by tatyana-krasnukha on Nov 14 2017, 5:20 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

source/Commands/CommandObjectTarget.cpp
2589

Removed these minuses, otherwise user should type option "----set-pc-to-entry"

labath accepted this revision.Nov 14 2017, 5:51 AM
This revision is now accepted and ready to land.Nov 14 2017, 5:51 AM
abidh accepted this revision.Nov 14 2017, 9:07 AM
clayborg accepted this revision.Nov 14 2017, 9:22 AM
clayborg added a subscriber: clayborg.

The "--set-pc-to-entry" change is fine. No need for review when removing unused variables or clang formatting, but it would be nice to do those commits separately.

ki.stfu accepted this revision.Nov 14 2017, 9:52 AM

I have not commit access, that is why I've decided to group all typos in one patch...

tatyana-krasnukha retitled this revision from Corrected two typos and removed unused variable to Remove extra minuses from command option.
tatyana-krasnukha edited the summary of this revision. (Show Details)

Things that didn't require review was committed separately.

Made diff with full paths (studying to use arcanist)...