This is an archive of the discontinued LLVM Phabricator instance.

Remove extra minuses from command option
ClosedPublic

Authored by tatyana-krasnukha on Nov 14 2017, 5:20 AM.

Download Raw Diff

Details

Reviewers

labath
abidh
clayborg
ki.stfu

Commits

rG70cf4dd735ef: Remove extra minuses from command option
rLLDB318846: Remove extra minuses from command option
rL318846: Remove extra minuses from command option

Diff Detail

Repository: rL LLVM

Event Timeline

tatyana-krasnukha created this revision.Nov 14 2017, 5:20 AM

Herald added a subscriber: ki.stfu. · View Herald TranscriptNov 14 2017, 5:20 AM

tatyana-krasnukha added inline comments.Nov 14 2017, 5:22 AM

source/Commands/CommandObjectTarget.cpp
2589	Removed these minuses, otherwise user should type option "----set-pc-to-entry"

labath accepted this revision.Nov 14 2017, 5:51 AM

This revision is now accepted and ready to land.Nov 14 2017, 5:51 AM

abidh accepted this revision.Nov 14 2017, 9:07 AM

The "--set-pc-to-entry" change is fine. No need for review when removing unused variables or clang formatting, but it would be nice to do those commits separately.

ki.stfu accepted this revision.Nov 14 2017, 9:52 AM

I have not commit access, that is why I've decided to group all typos in one patch...

Things that didn't require review was committed separately.

Made diff with full paths (studying to use arcanist)...

tatyana-krasnukha closed this revision.Nov 22 2017, 9:07 AM

Revision Contents

Path

Size

source/

Commands/

	CommandObjectTarget.cpp
	CommandObjectTarget.cpp (revision 318844)

2 lines

Diff 123953

source/Commands/CommandObjectTarget.cpp

Context not available.
	"Fullpath or basename for module to load.", ""),	"Fullpath or basename for module to load.", ""),
	m_load_option(LLDB_OPT_SET_1, false, "load", 'l',	m_load_option(LLDB_OPT_SET_1, false, "load", 'l',
	"Write file contents to the memory.", false, true),	"Write file contents to the memory.", false, true),
	m_pc_option(LLDB_OPT_SET_1, false, "--set-pc-to-entry", 'p',	m_pc_option(LLDB_OPT_SET_1, false, "set-pc-to-entry", 'p',
	tatyana-krasnukhaAuthorUnsubmitted Not Done Reply Inline Actions Removed these minuses, otherwise user should type option "----set-pc-to-entry" tatyana-krasnukha: Removed these minuses, otherwise user should type option "----set-pc-to-entry"
	"Set PC to the entry point."	"Set PC to the entry point."
	" Only applicable with '--load' option.",	" Only applicable with '--load' option.",
	false, true),	false, true),
Context not available.