Differential D39866

[WebAssembly] Fix stack offsets of return values from call lowering.
ClosedPublic
Actions

Authored by jbhateja on Nov 9 2017, 1:17 PM.

Tags

None

Subscribers

pepyakin, alexcrichton, jfb and 5 others

Details

Reviewers

vadimcn
alexcrichton

Commits

rL317895: [WebAssembly] Fix stack offsets of return values from call lowering.
rGaaa5944ad4ce: [WebAssembly] Fix stack offsets of return values from call lowering.

Summary

Fixes PR35220

Diff Detail

Repository: rL LLVM

Event Timeline

jbhateja created this revision.Nov 9 2017, 1:17 PM

Herald added subscribers: aheejin, jgravelle-google, sbc100 and 2 others. · View Herald TranscriptNov 9 2017, 1:17 PM

jbhateja added a reviewer: vadimcn.Nov 9 2017, 1:19 PM

alexcrichton added a subscriber: alexcrichton.Nov 10 2017, 1:16 AM

FWIW I've confirmed that this fixes the issue I was seeing and our entire test suite now passes, thanks again!

jbhateja added a reviewer: alexcrichton.Nov 10 2017, 5:18 AM

pepyakin added a subscriber: pepyakin.Nov 10 2017, 5:30 AM

alexcrichton accepted this revision.Nov 10 2017, 5:31 AM

This revision is now accepted and ready to land.Nov 10 2017, 5:31 AM

Closed by commit rL317895: [WebAssembly] Fix stack offsets of return values from call lowering. (authored by jbhateja). · Explain WhyNov 10 2017, 8:26 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (4 lines)
M			llvm/trunk/test/CodeGen/WebAssembly/umulo-i64.ll (13 lines)

Diff 122444

llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Loading...

llvm/trunk/test/CodeGen/WebAssembly/umulo-i64.ll

Loading...