Add code which does sign/zero extend.
Details
Diff Detail
Event Timeline
I've tried to ignore the bits that aren't supposed to be in this patch but it's possible I've ignored something important. Could you refresh the patch without the noise?
Please make it clear in the summary (and the title) that this is for MIPS FastISel? It won't be obvious to others when you come to commit
Is the testcase loadstoreconv.ll? I think there should also be a simpler test case that is just sign/zero extension by itself.
lib/Target/Mips/MipsFastISel.cpp | ||
---|---|---|
92–96 | Indentation nit. | |
248–249 |
The function name and implementation suggests that only sign extensions are supported. Zero extensions are in EmitIntZExt() | |
348–349 | The same is true for MIPS and the code below looks right but the comment references ARM. You'll need to run clang-format on the code though |
Is the testcase loadstoreconv.ll?
Disregard this, the test plan said it is. I still think a sign/zero extend only test is sensible though.
Executable test case. You can run this and compare results against it being run on x86.
Indentation nit.