This is an archive of the discontinued LLVM Phabricator instance.

Differential D39531

[test] Move llvm-lib tests into tools/llvm-lib. NFC.
ClosedPublic

Authored by mstorsjo on Nov 2 2017, 1:08 AM.

Details

Reviewers
pcc
ruiu
Commits
rG20910f46b60f: [test] Move llvm-lib tests into tools/llvm-lib. NFC.
rL317262: [test] Move llvm-lib tests into tools/llvm-lib. NFC.
Summary

Similarly to SVN r317189 for llvm-dlltool, these are probably easier to find in a tools subdirectory with a name identical to the tool, than in a toplevel directory with a different name.

This matches the move of LibDriver itself in SVN r302995.

Diff Detail

Event Timeline

mstorsjo created this revision.Nov 2 2017, 1:08 AM
Herald added a subscriber: mehdi_amini. · View Herald TranscriptNov 2 2017, 1:08 AM
ruiu accepted this revision.Nov 2 2017, 10:42 AM

LGTM

This revision is now accepted and ready to land.Nov 2 2017, 10:42 AM
Closed by commit rL317262: [test] Move llvm-lib tests into tools/llvm-lib. NFC. (authored by mstorsjo). · Explain WhyNov 2 2017, 1:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 121241

test/LibDriver/Inputs/a.s

  • This file was deleted.
.globl a
a:

test/LibDriver/Inputs/b.s

  • This file was deleted.
.globl b
b:

test/LibDriver/Inputs/cl-gl.obj

  • This binary file was deleted.
PropertyOld ValueNew Value
File Mode100755null

test/LibDriver/Inputs/resource.res

  • This binary file was deleted.

test/LibDriver/infer-output-path.test

  • This file was deleted.
RUN: rm -rf %t && mkdir -p %t
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/a.obj %S/Inputs/a.s
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/b.o %S/Inputs/b.s
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/c %S/Inputs/b.s
RUN: rm -f %t/a.lib
RUN: llvm-lib %t/a.obj
RUN: test -e %t/a.lib
RUN: rm -f %t/b.lib
RUN: llvm-lib /libpath:%t b.o
RUN: test -e %t/b.lib
RUN: rm -f %t/c.lib
RUN: llvm-lib /libpath:%t c
RUN: test -e %t/c.lib

test/LibDriver/invalid.test

  • This file was deleted.
RUN: not llvm-lib %S/Inputs/cl-gl.obj 2>&1 | FileCheck %s
CHECK: not a COFF object, bitcode or resource file

test/LibDriver/libpath.test

  • This file was deleted.
RUN: mkdir -p %t/a %t/b
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/a/foo.obj %S/Inputs/a.s
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/b/foo.obj %S/Inputs/b.s
RUN: env "LIB=%t/a;%t/b" llvm-lib /out:%t1.lib foo.obj
RUN: llvm-nm %t1.lib | FileCheck --check-prefix=A %s
RUN: llvm-lib /out:%t2.lib /libpath:%t/a /libpath:%t/b foo.obj
RUN: llvm-nm %t2.lib | FileCheck --check-prefix=A %s
RUN: env LIB=%t/a llvm-lib /libpath:%t/b /out:%t3.lib foo.obj
RUN: llvm-nm %t3.lib | FileCheck --check-prefix=B %s
A: T a
B: T b

test/LibDriver/lit.local.cfg

  • This file was deleted.
if not 'X86' in config.root.targets:
config.unsupported = True

test/LibDriver/no-inputs.test

  • This file was deleted.
RUN: llvm-lib -out:%t.a
RUN: test ! -e %t.a

test/LibDriver/resource.test

  • This file was deleted.
RUN: llvm-lib /out:%t %S/Inputs/resource.res
RUN: llvm-ar t %t | FileCheck %s
CHECK: resource.res

test/LibDriver/thin.test

  • This file was deleted.
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t %S/Inputs/a.s
RUN: llvm-lib -out:%t.a %t
RUN: FileCheck --check-prefix=FAT %s < %t.a
FAT: !<arch>
RUN: llvm-lib -out:%t.thin.a -llvmlibthin %t
RUN: FileCheck --check-prefix=THIN %s < %t.thin.a
THIN: !<thin>

test/LibDriver/use-paths.test

  • This file was deleted.
llvm-lib should behave like "link.exe /lib" and use relative paths to describe
archive members.
First, get in a clean working directory.
RUN: rm -rf %t && mkdir -p %t && cd %t
Make foo/a.obj and foo/b.obj.
RUN: mkdir foo
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o foo/a.obj %S/Inputs/a.s
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o foo/b.obj %S/Inputs/b.s
RUN: llvm-lib -out:foo.lib foo/a.obj foo/b.obj
RUN: llvm-ar t foo.lib | FileCheck %s
FIXME: We should probably use backslashes on Windows to better match MSVC tools.
CHECK: foo/a.obj
CHECK: foo/b.obj
Do it again with absolute paths and see that we get something.
RUN: llvm-lib -out:foo.lib %t/foo/a.obj %t/foo/b.obj
RUN: llvm-ar t foo.lib | FileCheck %s --check-prefix=ABS
ABS: {{.*}}/foo/a.obj
ABS: {{.*}}/foo/b.obj

test/tools/llvm-lib/Inputs/a.s

  • This file was added.
.globl a
a:

test/tools/llvm-lib/Inputs/b.s

  • This file was added.
.globl b
b:

test/tools/llvm-lib/Inputs/cl-gl.obj

  • This binary file was added.
PropertyOld ValueNew Value
File Modenull100755

test/tools/llvm-lib/Inputs/resource.res

  • This binary file was added.

test/tools/llvm-lib/infer-output-path.test

  • This file was added.
RUN: rm -rf %t && mkdir -p %t
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/a.obj %S/Inputs/a.s
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/b.o %S/Inputs/b.s
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/c %S/Inputs/b.s
RUN: rm -f %t/a.lib
RUN: llvm-lib %t/a.obj
RUN: test -e %t/a.lib
RUN: rm -f %t/b.lib
RUN: llvm-lib /libpath:%t b.o
RUN: test -e %t/b.lib
RUN: rm -f %t/c.lib
RUN: llvm-lib /libpath:%t c
RUN: test -e %t/c.lib

test/tools/llvm-lib/invalid.test

  • This file was added.
RUN: not llvm-lib %S/Inputs/cl-gl.obj 2>&1 | FileCheck %s
CHECK: not a COFF object, bitcode or resource file

test/tools/llvm-lib/libpath.test

  • This file was added.
RUN: mkdir -p %t/a %t/b
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/a/foo.obj %S/Inputs/a.s
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t/b/foo.obj %S/Inputs/b.s
RUN: env "LIB=%t/a;%t/b" llvm-lib /out:%t1.lib foo.obj
RUN: llvm-nm %t1.lib | FileCheck --check-prefix=A %s
RUN: llvm-lib /out:%t2.lib /libpath:%t/a /libpath:%t/b foo.obj
RUN: llvm-nm %t2.lib | FileCheck --check-prefix=A %s
RUN: env LIB=%t/a llvm-lib /libpath:%t/b /out:%t3.lib foo.obj
RUN: llvm-nm %t3.lib | FileCheck --check-prefix=B %s
A: T a
B: T b

test/tools/llvm-lib/lit.local.cfg

  • This file was added.
if not 'X86' in config.root.targets:
config.unsupported = True

test/tools/llvm-lib/no-inputs.test

  • This file was added.
RUN: llvm-lib -out:%t.a
RUN: test ! -e %t.a

test/tools/llvm-lib/resource.test

  • This file was added.
RUN: llvm-lib /out:%t %S/Inputs/resource.res
RUN: llvm-ar t %t | FileCheck %s
CHECK: resource.res

test/tools/llvm-lib/thin.test

  • This file was added.
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o %t %S/Inputs/a.s
RUN: llvm-lib -out:%t.a %t
RUN: FileCheck --check-prefix=FAT %s < %t.a
FAT: !<arch>
RUN: llvm-lib -out:%t.thin.a -llvmlibthin %t
RUN: FileCheck --check-prefix=THIN %s < %t.thin.a
THIN: !<thin>

test/tools/llvm-lib/use-paths.test

  • This file was added.
llvm-lib should behave like "link.exe /lib" and use relative paths to describe
archive members.
First, get in a clean working directory.
RUN: rm -rf %t && mkdir -p %t && cd %t
Make foo/a.obj and foo/b.obj.
RUN: mkdir foo
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o foo/a.obj %S/Inputs/a.s
RUN: llvm-mc -triple=x86_64-pc-windows-msvc -filetype=obj -o foo/b.obj %S/Inputs/b.s
RUN: llvm-lib -out:foo.lib foo/a.obj foo/b.obj
RUN: llvm-ar t foo.lib | FileCheck %s
FIXME: We should probably use backslashes on Windows to better match MSVC tools.
CHECK: foo/a.obj
CHECK: foo/b.obj
Do it again with absolute paths and see that we get something.
RUN: llvm-lib -out:foo.lib %t/foo/a.obj %t/foo/b.obj
RUN: llvm-ar t foo.lib | FileCheck %s --check-prefix=ABS
ABS: {{.*}}/foo/a.obj
ABS: {{.*}}/foo/b.obj
test/LibDriver/lit.local.cfg