This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Remove target to build native tablegen
ClosedPublic

Authored by Hahnfeld on Oct 25 2017, 10:31 AM.

Details

Summary

This was once needed so that multiple tablegen binaries don't compile
the library concurrently. However, this isn't needed anymore since
adding USES_TERMINAL to the custom_command.
This is supported by the fact that the target was only building
LLVMSupport since some cleanups a year ago. If this dependency had
really been needed, we would have seen complaints.

Diff Detail

Event Timeline

Hahnfeld created this revision.Oct 25 2017, 10:31 AM

Gentle ping

beanz accepted this revision.Nov 7 2017, 3:16 PM

LGTM.

This revision is now accepted and ready to land.Nov 7 2017, 3:16 PM
This revision was automatically updated to reflect the committed changes.