Make sure shifts are legal/specified by the legalizerinfo before creating it (in the LegalizerCombiner)
Details
Details
Diff Detail
Diff Detail
- Build Status
Buildable 11454 Build 11454: arc lint + arc unit
Event Timeline
Comment Actions
LGTM with nit.
include/llvm/CodeGen/GlobalISel/LegalizerCombiner.h | ||
---|---|---|
71 | You should check the same thing for G_AND and G_CONSTANT. |
include/llvm/CodeGen/GlobalISel/LegalizerCombiner.h | ||
---|---|---|
71 | Thanks. Will do it in the commit. |
llvm/trunk/include/llvm/CodeGen/GlobalISel/LegalizerCombiner.h | ||
---|---|---|
98 ↗ | (On Diff #120291) | You forgot this G_CONSTANT :) |
llvm/trunk/include/llvm/CodeGen/GlobalISel/LegalizerCombiner.h | ||
---|---|---|
98 ↗ | (On Diff #120291) | Fixed - r316694 |
You should check the same thing for G_AND and G_CONSTANT.