This is an archive of the discontinued LLVM Phabricator instance.

Differential D39221

[libcxx] [test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new
ClosedPublic

Authored by CaseyCarter on Oct 23 2017, 6:45 PM.

Details

Reviewers
EricWF
mclow.lists
STL_MSFT
Commits
rGdc2596e971b0: [test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new
rCXX318325: [test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new
rL318325: [test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new
Summary

Update aligned new tests to use __STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2 for "over-aligned" instead of alignof(std::max_align_t) * 2.

Diff Detail

Event Timeline

CaseyCarter created this revision.Oct 23 2017, 6:45 PM
EricWF accepted this revision.Nov 6 2017, 6:42 PM
This revision is now accepted and ready to land.Nov 6 2017, 6:42 PM
Closed by commit rL318325: [test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new (authored by CaseyCarter). · Explain WhyNov 15 2017, 11:15 AM
This revision was automatically updated to reflect the committed changes.
CaseyCarter mentioned this in rL318325: [test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new.

Revision Contents

Diff 119990

test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp

Show All 30 Lines
#include <new> #include <new>
#include <cstddef> #include <cstddef>
#include <cstdlib> #include <cstdlib>
#include <cassert> #include <cassert>
#include "test_macros.h" #include "test_macros.h"
constexpr auto OverAligned = alignof(std::max_align_t) * 2; constexpr auto OverAligned = __STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2;
int unsized_delete_called = 0; int unsized_delete_called = 0;
int unsized_delete_nothrow_called = 0; int unsized_delete_nothrow_called = 0;
int aligned_delete_called = 0; int aligned_delete_called = 0;
void reset() { void reset() {
unsized_delete_called = 0; unsized_delete_called = 0;
unsized_delete_nothrow_called = 0; unsized_delete_nothrow_called = 0;
▲ Show 20 Lines • Show All 54 Lines • Show Last 20 Lines

test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t.pass.cpp

Show All 32 Lines
#include <new> #include <new>
#include <cstddef> #include <cstddef>
#include <cassert> #include <cassert>
#include <cstdint> #include <cstdint>
#include <limits> #include <limits>
#include "test_macros.h" #include "test_macros.h"
constexpr auto OverAligned = alignof(std::max_align_t) * 2; constexpr auto OverAligned = __STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2;
int new_handler_called = 0; int new_handler_called = 0;
void my_new_handler() void my_new_handler()
{ {
++new_handler_called; ++new_handler_called;
std::set_new_handler(0); std::set_new_handler(0);
} }
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines

test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow.pass.cpp

Show All 31 Lines
#include <new> #include <new>
#include <cstddef> #include <cstddef>
#include <cstdint> #include <cstdint>
#include <cassert> #include <cassert>
#include <limits> #include <limits>
#include "test_macros.h" #include "test_macros.h"
constexpr auto OverAligned = alignof(std::max_align_t) * 2; constexpr auto OverAligned = __STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2;
int new_handler_called = 0; int new_handler_called = 0;
void my_new_handler() void my_new_handler()
{ {
++new_handler_called; ++new_handler_called;
std::set_new_handler(0); std::set_new_handler(0);
} }
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines

test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp

Show All 28 Lines
#include <new> #include <new>
#include <cstddef> #include <cstddef>
#include <cstdlib> #include <cstdlib>
#include <cassert> #include <cassert>
#include <limits> #include <limits>
#include "test_macros.h" #include "test_macros.h"
constexpr auto OverAligned = alignof(std::max_align_t) * 2; constexpr auto OverAligned = __STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2;
int A_constructed = 0; int A_constructed = 0;
struct alignas(OverAligned) A struct alignas(OverAligned) A
{ {
A() {++A_constructed;} A() {++A_constructed;}
~A() {--A_constructed;} ~A() {--A_constructed;}
}; };
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_replace.pass.cpp

Show All 18 Lines
#include <cstddef> #include <cstddef>
#include <cstdlib> #include <cstdlib>
#include <cstdint> #include <cstdint>
#include <cassert> #include <cassert>
#include <limits> #include <limits>
#include "test_macros.h" #include "test_macros.h"
constexpr auto OverAligned = alignof(std::max_align_t) * 2; constexpr auto OverAligned = __STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2;
int A_constructed = 0; int A_constructed = 0;
struct alignas(OverAligned) A { struct alignas(OverAligned) A {
A() { ++A_constructed;} A() { ++A_constructed;}
~A() { --A_constructed;} ~A() { --A_constructed;}
}; };
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines

test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp

Show All 29 Lines
#include <new> #include <new>
#include <cstddef> #include <cstddef>
#include <cstdlib> #include <cstdlib>
#include <cassert> #include <cassert>
#include "test_macros.h" #include "test_macros.h"
constexpr auto OverAligned = alignof(std::max_align_t) * 2; constexpr auto OverAligned = __STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2;
int unsized_delete_called = 0; int unsized_delete_called = 0;
int unsized_delete_nothrow_called = 0; int unsized_delete_nothrow_called = 0;
int aligned_delete_called = 0; int aligned_delete_called = 0;
void reset() { void reset() {
unsized_delete_called = 0; unsized_delete_called = 0;
unsized_delete_nothrow_called = 0; unsized_delete_nothrow_called = 0;
▲ Show 20 Lines • Show All 54 Lines • Show Last 20 Lines

test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t.pass.cpp

Show All 31 Lines
#include <new> #include <new>
#include <cstddef> #include <cstddef>
#include <cassert> #include <cassert>
#include <cstdint> #include <cstdint>
#include <limits> #include <limits>
#include "test_macros.h" #include "test_macros.h"
constexpr auto OverAligned = alignof(std::max_align_t) * 2; constexpr auto OverAligned = __STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2;
int new_handler_called = 0; int new_handler_called = 0;
void my_new_handler() void my_new_handler()
{ {
++new_handler_called; ++new_handler_called;
std::set_new_handler(0); std::set_new_handler(0);
} }
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines

test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow.pass.cpp

Show All 31 Lines
#include <new> #include <new>
#include <cstddef> #include <cstddef>
#include <cstdint> #include <cstdint>
#include <cassert> #include <cassert>
#include <limits> #include <limits>
#include "test_macros.h" #include "test_macros.h"
constexpr auto OverAligned = alignof(std::max_align_t) * 2; constexpr auto OverAligned = __STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2;
int new_handler_called = 0; int new_handler_called = 0;
void my_new_handler() void my_new_handler()
{ {
++new_handler_called; ++new_handler_called;
std::set_new_handler(0); std::set_new_handler(0);
} }
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines

test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp

Show All 29 Lines
#include <new> #include <new>
#include <cstddef> #include <cstddef>
#include <cstdlib> #include <cstdlib>
#include <cassert> #include <cassert>
#include <limits> #include <limits>
#include "test_macros.h" #include "test_macros.h"
constexpr auto OverAligned = alignof(std::max_align_t) * 2; constexpr auto OverAligned = __STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2;
bool A_constructed = false; bool A_constructed = false;
struct alignas(OverAligned) A struct alignas(OverAligned) A
{ {
A() {A_constructed = true;} A() {A_constructed = true;}
~A() {A_constructed = false;} ~A() {A_constructed = false;}
}; };
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines

test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_replace.pass.cpp

Show All 18 Lines
#include <cstddef> #include <cstddef>
#include <cstdlib> #include <cstdlib>
#include <cstdint> #include <cstdint>
#include <cassert> #include <cassert>
#include <limits> #include <limits>
#include "test_macros.h" #include "test_macros.h"
constexpr auto OverAligned = alignof(std::max_align_t) * 2; constexpr auto OverAligned = __STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2;
bool A_constructed = false; bool A_constructed = false;
struct alignas(OverAligned) A { struct alignas(OverAligned) A {
A() {A_constructed = true;} A() {A_constructed = true;}
~A() {A_constructed = false;} ~A() {A_constructed = false;}
}; };
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines