Page MenuHomePhabricator

[rename] support renaming class member.
ClosedPublic

Authored by hokein on Oct 23 2017, 3:34 AM.

Event Timeline

hokein created this revision.Oct 23 2017, 3:34 AM
ioeric accepted this revision.Oct 23 2017, 8:07 AM

Lgtm. Nice!

lib/Tooling/Refactoring/Rename/USRLocFinder.cpp
251

Is there a test case for this?

unittests/Rename/RenameMemberTest.cpp
207

Maybe add one more field in the test?

This revision is now accepted and ready to land.Oct 23 2017, 8:07 AM
hokein updated this revision to Diff 120216.Oct 25 2017, 2:32 AM
hokein marked 2 inline comments as done.
  • remove the code of handling template class methods as it is fixed in another patch.
  • address review comments.

I have refined the patch based on the D39241. Please take another look.

ioeric accepted this revision.Oct 25 2017, 2:37 AM

Still lgtm.

This revision was automatically updated to reflect the committed changes.